fix: avoid animation phase edge-case crashes

[Kizuno18]

Hey folks!

This is a small safety pass to avoid a couple of nasty edge cases that can crash the client when assets/thing types are incomplete or in a weird state.

• Guard null ThingType* before using it
• Guard getAnimationPhases() / getSpeed() against 0 to avoid divide-by-zero
• Clamp computed ticksPerFrame to at least 1
• Enable CRASH_HANDLER for MSVC builds so we get crashreport.log on Windows

No functional changes intended beyond not crashing in those scenarios.

Cheers!

Summary by CodeRabbit

• New Features

  • Added crash handler support for improved stability and error recovery

• Bug Fixes

  • Made animation phase logic robust with null-safety checks to avoid crashes
  • Hardened animation timing calculations to prevent invalid timing, division/modulo issues, and rendering glitches

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 956a7f1e-d051-42e1-a902-903a6747f937

📥 Commits

Reviewing files that changed from the base of the PR and between e188f3c and c981ca2.

📒 Files selected for processing (2)

• src/client/attachedeffect.cpp
• src/client/paperdoll.cpp

🚧 Files skipped from review as they are similar to previous changes (2)

• src/client/paperdoll.cpp
• src/client/attachedeffect.cpp

---

📝 Walkthrough

Walkthrough

Adds an MSVC compile definition CRASH_HANDLER for the otclient_core target and hardens animation-phase calculations in multiple client files by adding null checks and guarded, clamped timing arithmetic to prevent invalid/zero divisions.

Changes

Cohort / File(s)	Summary
Build Configuration src/CMakeLists.txt	Added target_compile_definitions(otclient_core PRIVATE CRASH_HANDLER) for MSVC builds.
Animation Phase Calculations src/client/attachedeffect.cpp, src/client/creature.cpp, src/client/paperdoll.cpp	getCurrentAnimationPhase(): early-return when thing type is null; validate animationPhases and speed; clamp ticksPerFrame to a minimum of 1; compute animationPeriod safely and use guarded modulo/division to derive phase. EOF newline fixes in two files.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I nibble through bytes with a careful hop,

Nulls checked, timers clipped, no more flop.
Crashes hushed and frames now glide,
A tiny patch, a confident stride.
—signed, the debugging rabbit 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: avoid animation phase edge-case crashes' directly and accurately describes the main objective of the changeset—adding safety guards and null checks to prevent client crashes in animation phase calculations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vllsystems]

Wouldn't it be good to add some warning logs to this PR?

[Kizuno18]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.