fix(charts): [charts]Pack and remove huicharts files #2897
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 140 files out of 247 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThis pull request refines the build and module mapping processes by modifying how chart components are handled. The changes include allowing certain chart components in simple mode by removing them from the exclusion list, eliminating special handling for components containing "Hui" in the entry generation, and adding a filter to skip files associated with huicharts during the module mapping. Additionally, several Huicharts-related components and dependencies have been removed from the module configuration and package files. Changes
Sequence Diagram(s)sequenceDiagram
participant User as CLI Command
participant AppEntry as build-entry-app.ts
participant Entry as build-entry.ts
participant Mapper as create-mapping.ts
participant Config as Module Config Files
User->>AppEntry: Initiate runtime build in simple mode
AppEntry->>Entry: Process component list (no special "Hui" handling)
Entry-->>AppEntry: Return built entry data
AppEntry->>User: Output full runtime entry
User->>Mapper: Start file mapping
Mapper->>File: Check file name for "huicharts"
alt File does NOT contain "huicharts"
File-->>Mapper: Include file for mapping
else File contains "huicharts"
File-->>Mapper: Exclude file
end
Mapper->>User: Complete modules JSON generation
User->>Config: Read updated Huicharts config (reduced set)
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request focuses on removing references to 'huicharts' from the codebase. It involves deleting specific chart components from the build entry files and updating the file filtering logic to exclude 'huicharts'. Additionally, it modifies the Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internals/cli/src/commands/create/create-mapping.ts (1)
54-59: Consider making the huicharts filter more robust.While the filter effectively excludes huicharts files, consider these improvements:
- Add a comment explaining why huicharts files are being excluded
- Use case-insensitive comparison to catch any case variations
fileFilter({ file }) { + // Exclude huicharts files as part of the removal of huicharts dependencies - if (file.includes('huicharts')) { + if (file.toLowerCase().includes('huicharts')) { return false } return !/node_modules|helper|common|assets/.test(file) },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
internals/cli/src/commands/build/build-entry-app.ts(0 hunks)internals/cli/src/commands/build/build-entry.ts(0 hunks)internals/cli/src/commands/create/create-mapping.ts(1 hunks)packages/modules.json(0 hunks)packages/vue/package.json(0 hunks)
💤 Files with no reviewable changes (4)
- internals/cli/src/commands/build/build-entry.ts
- internals/cli/src/commands/build/build-entry-app.ts
- packages/vue/package.json
- packages/modules.json
🔇 Additional comments (1)
internals/cli/src/commands/create/create-mapping.ts (1)
46-99: LGTM! The huicharts filter integrates well with the module mapping process.The implementation correctly excludes huicharts files while maintaining the integrity of the module mapping process for other components. This aligns well with the PR's objective of removing huicharts dependencies.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Refactor
Chores