Skip to content

Conversation

@gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Oct 17, 2025

PR

表格极简个性化设置移除调无用的tooltip提示
image

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue in grid column configuration where items missing required properties could cause display problems. Invalid entries are now properly filtered during processing.
  • New Features
    • Added tooltip configuration that displays contextually for improved user experience.

@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2025

Walkthrough

The custom-select component is updated with tooltip configuration and defensive null filtering. A tooltip-config prop is bound to TinySelect with always-false setting. Column config extraction adds null guards for items missing a property, filtering these null entries from results.

Changes

Cohort / File(s) Summary
Tooltip Configuration
packages/vue/src/grid-toolbar/src/custom-select.vue
Added :tooltip-config="{ always: false }" prop binding to the TinySelect component to control tooltip visibility behavior.
Column Config Filtering
packages/vue/src/grid-toolbar/src/custom-select.vue
Introduced null guard in getColNodes that returns null for items without a property, followed by filtering to remove null entries from column configuration extraction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tooltip whispers soft and low,
With always: false, it won't show,
While columns cleanse their missing parts,
Null guards defend with careful hearts,
Small tweaks that make the ui smart! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The PR title "fix(grid): gird simple custom config remove tooltip" clearly relates to the main change in the changeset. The changes add a tooltip-config binding to the TinySelect component with always: false, which effectively disables the tooltip from the grid's simple custom configuration UI. The title accurately conveys the primary objective stated in the PR description—removing an unnecessary tooltip from the table's personalization settings UI. While there is a minor typo ("gird" instead of "grid"), the title remains sufficiently clear and specific for teammates to understand the main change being made.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cgm/grid-toolbar-no-tooltip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gimmyhehe gimmyhehe changed the title fix(grid): simple custom config remove tooltip fix(grid): gird simple custom config remove tooltip Oct 17, 2025
@zzcr zzcr merged commit e5ee590 into dev Oct 27, 2025
14 of 16 checks passed
@zzcr zzcr deleted the cgm/grid-toolbar-no-tooltip branch October 27, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants