Fix DXGLContext dispose #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dispose and added calls to dispose before throwing an exception in ctor
NogginBops
reviewed
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of things related to
DXGLContextdispose:DXCloseDeviceNVwith an emptyGLDeviceHandlecrashes with AccessViolationException. This checks ifGLDeviceHandleisn't empty beforehand.GlwfWindowcan only be disposed on main thread.In my case I can now properly handle when the control can't initialize on integrated gpus without crashing. Maybe fixes 113 and 132 as they're similar to what I've encountered (though these may not be related as I now see that NativeWindow also has a finalizer).