Skip to content

Commit

Permalink
Merge pull request #13 from opentok/0.3.5
Browse files Browse the repository at this point in the history
0.3.5
  • Loading branch information
Manik Sachdeva authored Apr 9, 2018
2 parents 6538885 + ee6cc5a commit 95bcbf8
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 49 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@

5. Open XCode

6. Open <YourProjectName>.xcworkspace file in XCode. This file can be found in the `ios` folder.
6. Open `<YourProjectName>.xcworkspace` file in XCode. This file can be found in the `ios` folder of your React Native project.

7. Click `File` and `Add Files to`

8. Add the following files to the project:
8. Add the following files from `../node_modules/opentok-react-native/ios` to the project:
* `OTPublisher.h`
* `OTPublisher.m`
* `OTPublisherManager.swift`
Expand All @@ -70,10 +70,11 @@
* `OTSubscriber.m`
* `OTSubscriberManager.swift`
* `OTSubscriberView.swift`
* `<YourProjectName>-Bridging-Header.h`

9. Click `Create Bridging Header` when you're prompted with the following modal: `Would you like to configure an Objective-C bridging header?`

10. Add the contents from the `Bridging-Header.h` file in `../node_modules/opentok-react-native/ios` to `<YourProjectName>-Bridging-Header.h`

### Android Installation

1. In you terminal, change into your project directory.
Expand Down
6 changes: 0 additions & 6 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

apply plugin: 'com.android.library'

android {
Expand All @@ -10,16 +9,11 @@ android {
targetSdkVersion 23
versionCode 1
versionName "1.0"
ndk {
abiFilters "armeabi-v7a", "x86"
}
}
}

dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.android.support:appcompat-v7:23.0.1"
compile "com.facebook.react:react-native:+" // From node_modules
compile 'com.opentok.android:opentok-android-sdk:2.13.0'
compile 'com.android.volley:volley:1.1.0'
}
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
{
"name": "opentok-react-native",
"version": "0.3.4",
"version": "0.3.5",
"description": "React Native components for OpenTok iOS and Android SDKs",
"main": "src/index.js",
"homepage": "www.tokbox.com",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"postinstall": "node ./scripts/postInstall"
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [
"opentok",
Expand Down
34 changes: 0 additions & 34 deletions scripts/postInstall.js

This file was deleted.

4 changes: 2 additions & 2 deletions src/OTSession.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@ export default class OTSession extends Component {
}
disconnectSession() {
OT.disconnectSession((disconnectError) => {
if (disconnectError) {
if (!disconnectError) {
this.setState({
sessionInfo: null,
});
} else {
handleError(error);
handleError(disconnectError);
}
});
}
Expand Down

0 comments on commit 95bcbf8

Please sign in to comment.