Skip to content

Update to version 3.0 client and update interfaces #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions opentracing-kafka-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<artifactId>kafka-clients</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.30</version>
</dependency>
</dependencies>

</project>
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.OptionalLong;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.function.BiFunction;
Expand Down Expand Up @@ -224,7 +225,7 @@ public Map<TopicPartition, OffsetAndMetadata> committed(Set<TopicPartition> part
public Map<TopicPartition, OffsetAndMetadata> committed(Set<TopicPartition> partitions,
final Duration timeout) {
return consumer.committed(partitions, timeout);
}
}

@Override
public Map<MetricName, ? extends Metric> metrics() {
Expand Down Expand Up @@ -300,6 +301,11 @@ public Map<TopicPartition, Long> endOffsets(Collection<TopicPartition> collectio
return consumer.endOffsets(collection, duration);
}

@Override
public OptionalLong currentLag(final TopicPartition topicPartition) {
return consumer.currentLag(topicPartition);
}

@Override
public ConsumerGroupMetadata groupMetadata() {
return consumer.groupMetadata();
Expand All @@ -311,14 +317,13 @@ public void enforceRebalance() {
}

@Override
public void close() {
consumer.close();
public void enforceRebalance(final String s) {
consumer.enforceRebalance(s);
}

@Override
@Deprecated
public void close(long l, TimeUnit timeUnit) {
consumer.close(l, timeUnit);
public void close() {
consumer.close();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,4 @@ public void close(Duration duration) {
producer.close(duration);
}

@Override
public void close(long timeout, TimeUnit timeUnit) {
producer.close(timeout, timeUnit);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ public void test() {
await().atMost(15, TimeUnit.SECONDS).until(reportedSpansSize(), greaterThanOrEqualTo(3));

List<MockSpan> spans = mockTracer.finishedSpans();
spans.forEach(s -> System.out.println("Span Operation: " + s.operationName()));
assertThat(spans, contains(
new SpanMatcher("To_spring"),
new SpanMatcher("From_spring"),
new SpanMatcher("To_spring"),
new SpanMatcher("KafkaListener_spring")));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import java.util.Collections;
import java.util.Map;
import java.util.function.BiFunction;

import org.apache.kafka.clients.admin.Admin;
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.consumer.Consumer;
import org.apache.kafka.clients.consumer.ConsumerRecord;
Expand Down Expand Up @@ -95,6 +97,11 @@ public AdminClient getAdminClient(final Map<String, Object> config) {
return AdminClient.create(config);
}

@Override
public Admin getAdmin(final Map<String, Object> config) {
return this.getAdminClient(config);
}

@Override
public Producer<byte[], byte[]> getProducer(Map<String, Object> config) {
return new TracingKafkaProducerBuilder<>(
Expand Down
14 changes: 7 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@
</issueManagement>

<properties>
<java.version>1.8</java.version>
<java.version>11</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>

<opentracing.version>0.33.0</opentracing.version>
<kafka.version>2.6.0</kafka.version>
<spring.kafka.version>2.6.1</spring.kafka.version>
<opentracing.version>0.32.0</opentracing.version>
<kafka.version>3.2.1</kafka.version>
<spring.kafka.version>2.9.0</spring.kafka.version>
<spring.version>5.2.7.RELEASE</spring.version>
<coveralls-maven-plugin.version>4.3.0</coveralls-maven-plugin.version>
<jacoco-maven-plugin.version>0.8.5</jacoco-maven-plugin.version>
Expand Down Expand Up @@ -128,7 +128,7 @@
</exclusion>
<exclusion>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka_2.11</artifactId>
<artifactId>kafka_2.12</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.kafka</groupId>
Expand Down Expand Up @@ -268,7 +268,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.2.0</version>
<version>3.2.1</version>
<executions>
<execution>
<id>attach-sources</id>
Expand All @@ -282,7 +282,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.1.1</version>
<version>3.4.1</version>
<configuration>
<failOnError>false</failOnError>
</configuration>
Expand Down