Update location for go-grpc. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
May 18, 2018
yurishkuro
reviewed
May 18, 2018
| @@ -23,7 +23,7 @@ The following are all on the OpenTracing instrumentation short-list: | |||
| - [x] [Finagle](https://github.com/twitter/finagle/pull/520#issuecomment-249959538)... almost :confused: | |||
| - [x] [Flask](https://github.com/opentracing-contrib/python-flask) | |||
| - [ ] gRPC: | |||
| - [x] [Go](https://github.com/grpc-ecosystem/grpc-opentracing/tree/master/go/otgrpc) | |||
There was a problem hiding this comment.
what happened to to https://github.com/grpc-ecosystem/grpc-opentracing/ ? Should it be archived and README updated to refer to opentracing-contrib/go-grpc ?
There was a problem hiding this comment.
That repository wasn't being maintained well.
Not many people had write access and grouping all the languages into one repo meant that a lot of the issues were being ignored. See @tedsuo's comments: https://gitter.im/opentracing/public?at=5a32ca19ba39a53f1a5f481a
But I also put in a PR to redirect go from there: grpc-ecosystem/grpc-opentracing#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.