Cover more production use-cases #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so users can avoid repeating `childOf: nil` for root spans.
…tags-and-log-fields Define constants for standard tags and log fields
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋. At Datadog we're close to releasing an alpha version of our tracer. Few weeks ago we forked the
opentracing-swiftto update it with our production use cases, hence I open this PR to propose our follow-up contributions:swift-tools-versionto more recent;tracer.startSpan(operationName:)without forcingchildOf: nil.This PR is a proposal and might require more work on our side to make it beneficial for a wider audience.
As Datadog, we'd like to help with
opentracing-swiftso we can have more impact and safely make it a dependency for ourdd-sdk-ios.