Add script to reduce the Portland GTFS test data set #6023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
changed the title
t2gran
force-pushed
the
otp2_add_script_to_modify_portland_gtfs_test_data
branch
from
eafb374 to
325504d
Compare
…a set. This script can be used to debug test witch only uses a subset of the trips - removing the other trips makes it easier to debug.
t2gran
force-pushed
the
otp2_add_script_to_modify_portland_gtfs_test_data
branch
from
325504d to
896cd99
Compare
|
There are other better tools for this and I am not sure I ever need it again, so I will close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replace the Portland GTFS zip file with a catalog with text files(not compressed). It also add a script to modify the GTFS files. The script can remove routes from the dataset, this is useful in cases where you are debugging an integration test. For example, if the search only uses one or two trips only those trips need to exist in the data set - the expected result should be the same.
The unzipping of the GTFS file make inspection of the Portland test data easier - so I what to merge that, but If we want to merge the script is up to the community - if no one, except me, find it useful then we should not merge it.
The data-files are not changed in any way - only unzipped.
Issue
🟥 There is no issue for this PR. This PR does not change OTP code, only unzip test data.
Unit tests
✅ The only code changed is the location of the test data - coverd by tests and the script. The script does not have unit test, but can be verified simply by running it and inspect the data text files.
Documentation
✅ The script is documented at the top of the file. No other doc is added.
Changelog
🟥 This is a developer util, not relevant for the change log.
Bumping the serialization version id
🟥 Not applicable.