-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add via to the Transmodel trip query and make a proper Raptor implementation for it #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om dynamicSearchParamsCalculator)
This extract logic to merge a hierarchy of objects containing composites, flatten the structure into one list of elements. There is a small performance optimization, but the important thing is that we will use this later in the design later.
t2gran
added
New Feature
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
labels
Sep 22, 2024
Parameters for via locations with wait-time and allowAsPassThroughPoint flag are added.
t2gran
commented
Oct 9, 2024
src/main/java/org/opentripplanner/apis/transmodel/support/OneOfInputValidator.java
Show resolved
Hide resolved
…fInputValidator.java
optionsome
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the resolved comments from me where addressed, but there are still some unresolved comments.
src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql
Outdated
Show resolved
Hide resolved
…configure/StdRangeRaptorConfig.java Co-authored-by: Henrik Abrahamsson <127481124+habrahamsson-skanetrafiken@users.noreply.github.com>
optionsome
previously approved these changes
Oct 10, 2024
habrahamsson-skanetrafiken
requested changes
Oct 10, 2024
src/main/java/org/opentripplanner/raptor/rangeraptor/transit/AccessPaths.java
Outdated
Show resolved
Hide resolved
habrahamsson-skanetrafiken
approved these changes
Oct 10, 2024
optionsome
approved these changes
Oct 10, 2024
leonardehrenfried
approved these changes
Oct 10, 2024
t2gran
pushed a commit
that referenced
this pull request
Oct 10, 2024
t2gran
pushed a commit
that referenced
this pull request
Oct 10, 2024
t2gran
added a commit
to entur/OpenTripPlanner-LegacyHSLFork
that referenced
this pull request
Oct 15, 2024
The list of ids inside passThroughPoints is allowed to be empty or null. We cannot change this - that would be a breaking change. So, when the via search enforced this, the API was not backward compatible anymore. This commit reverts the behavior and just ignores the passThroughPoints if the list of ids is null or empty. This bug was introduced in PR opentripplanner#6084.
t2gran
added a commit
to entur/OpenTripPlanner-LegacyHSLFork
that referenced
this pull request
Oct 16, 2024
The list of ids inside passThroughPoints is allowed to be empty or null. We cannot change this - that would be a breaking change. So, when the via search enforced this, the API was not backward compatible anymore. This commit reverts the behavior and just ignores the passThroughPoints if the list of ids is null or empty. This bug was introduced in PR opentripplanner#6084.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
High Priority
High priority for review and issues
New Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add back the via search to the Transmodel plan query. It does so by "chaining" Raptor requests. To be able to do this I had to refactor quite a bit. The functional changes is not that big.
This PR changes the Transmodel API and add a via location to the plan request. The
passThrough
feature works as before, but is merged with the new via API, and the oldpassThrough
arguments are deprecated.There are a few things left to implement:
I will create issues for reminding features, when this is merged.
The feature is a bit experimental and need "real life" testing - small changes and bug fixes are expected.
If this PR is too massive, then I can split it - but I believe there is little risk in breaking existing functionality. Splitting it in a pure feature PR and refactorings is difficult.
Issue
Related to : #4887
Unit tests
This PR refactor a lot of code and also add missing unit-test to some of the refactored classes. Almost all new code have unit-tests.
Documentation
✅ The API is documented and all new public classes/methods should have JavaDoc.
Changelog
✅
Bumping the serialization version id
✅ The routing request is changed