Skip to content

Add wheelchair accessible checkbox to Debug UI #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

a-limyr
Copy link
Contributor

@a-limyr a-limyr commented Sep 26, 2024

Summary

Adds wheelchair accessible checkbox to the Debug UI. The checkbox affects the both the results of the Route button and the GraphiQL button.

Issue

Issue: Debug UI is missing wheelchair accessible option
Fix: Added a new checkbox element for wheelchair accessible searches. The trip query adds wheelchairAccessible as true or false based on the new checkbox.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (eccee39) to head (25194e2).
Report is 186 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6090      +/-   ##
=============================================
+ Coverage      69.78%   69.83%   +0.04%     
- Complexity     17359    17460     +101     
=============================================
  Files           1962     1975      +13     
  Lines          74359    74624     +265     
  Branches        7624     7638      +14     
=============================================
+ Hits           51893    52115     +222     
- Misses         19823    19857      +34     
- Partials        2643     2652       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-limyr a-limyr marked this pull request as ready for review September 26, 2024 09:48
@a-limyr a-limyr requested a review from a team as a code owner September 26, 2024 09:48
@leonardehrenfried
Copy link
Member

I'm making the search bar more compact over at #6091.

How does this affect overflow?

@leonardehrenfried
Copy link
Member

And can I see a screenshot?

@leonardehrenfried
Copy link
Member

When the search bar gets too crowded we might have to come up with a UI for "extended parameters".

@a-limyr
Copy link
Contributor Author

a-limyr commented Sep 27, 2024

Screenshot 2024-09-27 at 09 34 51
It adds a checkbox between "Itinerary filter debug" and "Route" button. When it comes to overflow it will just align with the other parameters.
I guess there should be a revamp of the parameter layout, because it is a bit messy today, and will probably grow even more in the future.

@a-limyr
Copy link
Contributor Author

a-limyr commented Sep 27, 2024

Screenshot 2024-09-27 at 09 43 26
I have an initial suggestion when it comes to a layout. This will be a tab-based approach that will logically group filters into different tabs.

@leonardehrenfried
Copy link
Member

That's a lot of words for a small check box. Would it be enough to just say "Wheelchair" or add an icon? https://thenounproject.com/search/icons/?q=wheelchair

@a-limyr
Copy link
Contributor Author

a-limyr commented Sep 27, 2024

Agree, I will make this change.

@leonardehrenfried
Copy link
Member

Let me know if you want me to download something from noun project. I have a paid account.

@a-limyr
Copy link
Contributor Author

a-limyr commented Sep 27, 2024

Yes, a suitable wheelchair icon would be nice!

@leonardehrenfried
Copy link
Member

leonardehrenfried commented Sep 27, 2024

Check your email. :)

@a-limyr
Copy link
Contributor Author

a-limyr commented Sep 27, 2024

Thank you. I have changed the code now to add an icon instead of text. The result is like this:
Screenshot 2024-09-27 at 10 49 24

@leonardehrenfried leonardehrenfried merged commit f285066 into opentripplanner:dev-2.x Sep 30, 2024
6 checks passed
@t2gran t2gran deleted the debug-ui-wheelchair-accessible branch October 9, 2024 21:12
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants