Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing transit modes in GTFS GraphQL InputModeWeight #6101

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Sep 30, 2024

Summary

Add missing transit modes in GTFS GraphQL InputModeWeight

Issue

Fixes #6100

Unit tests

Not testable

Documentation

  • GraphQL documentation added

@miklcct miklcct marked this pull request as ready for review October 2, 2024 15:30
@miklcct miklcct requested a review from a team as a code owner October 2, 2024 15:30
@optionsome optionsome self-requested a review October 3, 2024 13:41
@optionsome
Copy link
Member

I think this addition is ok but we are starting to move away from using the old plan query, it's being deprecated in favour of the planConnection query in the scope of #6110. One small thing, the autogenerated data fetcher/type files automatically get unused/duplicate imports. Can you clean those away? If you are using intellij, it has an optimize imports action that does it.

@miklcct
Copy link
Contributor Author

miklcct commented Oct 4, 2024 via email

@optionsome
Copy link
Member

It's fine to clean up the imports there even though you shouldn't edit it by hand otherwise. We have discussed a while back should we clean those imports or not since they get generated every time but it's quite quick to do once you get used to it.

@habrahamsson-skanetrafiken
Copy link
Contributor

This has merge conflicts, could you please resolve them?

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
@leonardehrenfried
Copy link
Member

This needs a rebase. There was some confusing breakage when Github Actions installs pip packages. I hope it's now fixed on dev-2.x.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.91%. Comparing base (440498f) to head (0660e75).
Report is 60 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ntripplanner/apis/gtfs/generated/GraphQLTypes.java 0.00% 20 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6101      +/-   ##
=============================================
- Coverage      69.93%   69.91%   -0.02%     
+ Complexity     17730    17728       -2     
=============================================
  Files           1996     1996              
  Lines          75402    75422      +20     
  Branches        7717     7717              
=============================================
- Hits           52731    52730       -1     
- Misses         19995    20016      +21     
  Partials        2676     2676              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optionsome optionsome merged commit 559fac5 into opentripplanner:dev-2.x Oct 22, 2024
5 checks passed
@miklcct miklcct deleted the gql-mode-weight branch October 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTFS GraphQL API modeWeight doesn't support all transport modes
6 participants