-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing transit modes in GTFS GraphQL InputModeWeight #6101
Conversation
c2009dc
to
306233a
Compare
I think this addition is ok but we are starting to move away from using the old plan query, it's being deprecated in favour of the |
The file says do not edit by hand. Should we just leave them there as is instead? Otherwise it will confuse future contributors if the same change is generated over and over again.
4 Oct 2024 13:55:15 Joel Lappalainen ***@***.***>:
…
I think this addition is ok but we are starting to move away from using the old plan query, it's being deprecated in favour of the *planConnection* query in the scope of #6110[#6110]. One small thing, the autogenerated data fetcher/type files automatically get unused/duplicate imports. Can you clean those away? If you are using intellij, it has an optimize imports action that does it.
—
Reply to this email directly, view it on GitHub[#6101 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAVSIAGWJVP6O4AB6O24W6DZZ2F3HAVCNFSM6AAAAABPDHZG76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTGY2DKMRZHA].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/AAVSIADPKSEV34RGQQFHVRTZZ2F3HA5CNFSM6AAAAABPDHZG76WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUOVQQPE.gif]
|
It's fine to clean up the imports there even though you shouldn't edit it by hand otherwise. We have discussed a while back should we clean those imports or not since they get generated every time but it's quite quick to do once you get used to it. |
This has merge conflicts, could you please resolve them? |
This needs a rebase. There was some confusing breakage when Github Actions installs pip packages. I hope it's now fixed on dev-2.x. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6101 +/- ##
=============================================
- Coverage 69.93% 69.91% -0.02%
+ Complexity 17730 17728 -2
=============================================
Files 1996 1996
Lines 75402 75422 +20
Branches 7717 7717
=============================================
- Hits 52731 52730 -1
- Misses 19995 20016 +21
Partials 2676 2676 ☔ View full report in Codecov by Sentry. |
e3651a2
to
0660e75
Compare
Summary
Add missing transit modes in GTFS GraphQL InputModeWeight
Issue
Fixes #6100
Unit tests
Not testable
Documentation