-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traversal permissions debug layer #6114
Traversal permissions debug layer #6114
Conversation
84884e0
to
21accc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6114 +/- ##
=============================================
+ Coverage 69.74% 69.93% +0.19%
- Complexity 17627 17715 +88
=============================================
Files 1996 1996
Lines 75305 75365 +60
Branches 7705 7705
=============================================
+ Hits 52519 52705 +186
+ Misses 20110 19989 -121
+ Partials 2676 2671 -5 ☔ View full report in Codecov by Sentry. |
6b56145
to
700d4ef
Compare
0d7dc48
to
eba10a6
Compare
I think I might need a walkthrough of this. After the otp days? |
Or we run a workshop during the OTP days and you join remotely. |
I can't promise anything but if you suggest some time slots I can check how it fits |
Friday is pretty free and I'm planning the workshop at 11.15. Does this work for you? We are pretty flexible on time though. |
I should be able to make Friday 11:15! |
You should have a calendar invite in your email. If not, please get in touch. |
With @flaktack's latest edge offset PR it now looks like this: |
180c447
to
ead941e
Compare
Summary
This adds a traversal permissions layer to the new debug UI. It looks like this:
It also adds layer groups so that you can switch a bunch of layers on/off with a single click.
@testower I acknowledge that this adds bunch of jQuery-style DOM hackery to the LayerControl but I think we said last time that it's impossible/very hard to use React for that.
Future work
An OSM way is usually split into a forward and backward edge and they can have different permissions. This isn't visualised well at the moment.
Issue
#5330