Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traversal permissions debug layer #6114

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Oct 4, 2024

Summary

This adds a traversal permissions layer to the new debug UI. It looks like this:

image

It also adds layer groups so that you can switch a bunch of layers on/off with a single click.

@testower I acknowledge that this adds bunch of jQuery-style DOM hackery to the LayerControl but I think we said last time that it's impossible/very hard to use React for that.

Future work

An OSM way is usually split into a forward and backward edge and they can have different permissions. This isn't visualised well at the moment.

Issue

#5330

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner October 4, 2024 07:40
@leonardehrenfried leonardehrenfried force-pushed the layer-groups branch 2 times, most recently from 84884e0 to 21accc4 Compare October 4, 2024 07:48
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (d678671) to head (ead941e).
Report is 64 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6114      +/-   ##
=============================================
+ Coverage      69.74%   69.93%   +0.19%     
- Complexity     17627    17715      +88     
=============================================
  Files           1996     1996              
  Lines          75305    75365      +60     
  Branches        7705     7705              
=============================================
+ Hits           52519    52705     +186     
+ Misses         20110    19989     -121     
+ Partials        2676     2671       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@testower
Copy link
Contributor

testower commented Oct 7, 2024

I think I might need a walkthrough of this. After the otp days?

@leonardehrenfried
Copy link
Member Author

Or we run a workshop during the OTP days and you join remotely.

@testower
Copy link
Contributor

testower commented Oct 8, 2024

I can't promise anything but if you suggest some time slots I can check how it fits

@leonardehrenfried
Copy link
Member Author

Friday is pretty free and I'm planning the workshop at 11.15. Does this work for you?

We are pretty flexible on time though.

@testower
Copy link
Contributor

testower commented Oct 8, 2024

I should be able to make Friday 11:15!

@leonardehrenfried
Copy link
Member Author

You should have a calendar invite in your email. If not, please get in touch.

@leonardehrenfried
Copy link
Member Author

With @flaktack's latest edge offset PR it now looks like this:
Screenshot from 2024-10-09 21-41-17

flaktack
flaktack previously approved these changes Oct 11, 2024
client/src/components/MapView/LayerControl.tsx Outdated Show resolved Hide resolved
client/src/components/MapView/LayerControl.tsx Outdated Show resolved Hide resolved
client/src/components/MapView/LayerControl.tsx Outdated Show resolved Hide resolved
client/src/components/MapView/LayerControl.tsx Outdated Show resolved Hide resolved
client/src/components/MapView/LayerControl.tsx Outdated Show resolved Hide resolved
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
@leonardehrenfried leonardehrenfried merged commit 489e9b1 into opentripplanner:dev-2.x Oct 17, 2024
6 checks passed
@leonardehrenfried leonardehrenfried deleted the layer-groups branch October 17, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants