Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SIRI to OTP main source tree #6121

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

vpaturet
Copy link
Contributor

@vpaturet vpaturet commented Oct 8, 2024

Summary

This PR promotes the SIRI real-time updaters from the sandbox to the main OTP source tree.
The Azure implementation stays for now in the sandbox and will be subsequently refactored.

Out of scope for this PR:

  • Making naming conventions consistent between GTFS and NeTEx updaters
  • Moving classes shared between GTFS and NeTEx updaters (ex.: TimetableSnapshotManager, ...) to an appropriate package.

Breaking change: logback configurations should be updated to reflect the new package name.

Issue

#6048

Unit tests

No

Documentation

No

@vpaturet vpaturet added Technical Debt NeTEx This issue is related to the Netex model/import. Real-Time Update The issue/PR is related to RealTime updates Skip Changelog labels Oct 8, 2024
@vpaturet vpaturet self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.85%. Comparing base (58a1847) to head (57ae55f).
Report is 3 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6121      +/-   ##
=============================================
- Coverage      69.85%   69.85%   -0.01%     
- Complexity     17497    17498       +1     
=============================================
  Files           1976     1976              
  Lines          74710    74710              
  Branches        7645     7645              
=============================================
- Hits           52192    52189       -3     
- Misses         19868    19870       +2     
- Partials        2650     2651       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vpaturet vpaturet marked this pull request as ready for review October 8, 2024 12:33
@vpaturet vpaturet requested a review from a team as a code owner October 8, 2024 12:33
@vpaturet vpaturet force-pushed the move_siri_out_of_sandbox branch 2 times, most recently from f1b8202 to cd2ff94 Compare October 8, 2024 13:52
@vpaturet vpaturet force-pushed the move_siri_out_of_sandbox branch from cd2ff94 to c252e90 Compare October 8, 2024 13:59
@vpaturet vpaturet merged commit 2ef3d81 into opentripplanner:dev-2.x Oct 8, 2024
5 checks passed
@vpaturet vpaturet deleted the move_siri_out_of_sandbox branch October 8, 2024 15:21
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeTEx This issue is related to the Netex model/import. Real-Time Update The issue/PR is related to RealTime updates Skip Changelog Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants