-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OSM type names consistent #6131
Make OSM type names consistent #6131
Conversation
Should we change the org.opentripplanner.openstreetmap package name? |
I would vote yes to that. What do you think? |
Don't have a strong opinion on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename
There are still some methods that use OSM at least, do we rename those as well in the scope of this pr? |
Can you point them out? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6131 +/- ##
=============================================
- Coverage 69.85% 69.85% -0.01%
Complexity 17494 17494
=============================================
Files 1976 1976
Lines 74705 74705
Branches 7643 7643
=============================================
- Hits 52188 52185 -3
- Misses 19868 19870 +2
- Partials 2649 2650 +1 ☔ View full report in Codecov by Sentry. |
AreaGroup#getSomeOSMObject We also generate issue store entry with name "OSMOpeningHoursUnparsed" |
There are conflicts now |
Summary
Renames all OSM types from
OSM*
andOpenStreetMap*
toOsm*
to make them consistent.Relates to #6048