Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OSM type names consistent #6131

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Oct 9, 2024

Summary

Renames all OSM types from OSM* and OpenStreetMap* to Osm* to make them consistent.

Relates to #6048

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner October 9, 2024 12:18
@leonardehrenfried leonardehrenfried added the bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR label Oct 9, 2024
@optionsome optionsome self-requested a review October 9, 2024 12:32
@vpaturet vpaturet self-requested a review October 9, 2024 12:35
@optionsome
Copy link
Member

Should we change the org.opentripplanner.openstreetmap package name?

@leonardehrenfried
Copy link
Member Author

I would vote yes to that. What do you think?

@optionsome
Copy link
Member

I would vote yes to that. What do you think?

Don't have a strong opinion on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename

@optionsome
Copy link
Member

There are still some methods that use OSM at least, do we rename those as well in the scope of this pr?

@leonardehrenfried
Copy link
Member Author

Can you point them out?

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (d2b7cdd) to head (c0ef46d).
Report is 13 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...pplanner/graph_builder/module/osm/OsmDatabase.java 91.30% 4 Missing ⚠️
...n/java/org/opentripplanner/osm/model/OsmLevel.java 42.85% 3 Missing and 1 partial ⚠️
...opentripplanner/graph_builder/module/osm/Area.java 66.66% 2 Missing and 1 partial ⚠️
...r/graph_builder/module/osm/AreaTooComplicated.java 0.00% 2 Missing ⚠️
..._builder/issues/InvalidVehicleParkingCapacity.java 0.00% 1 Missing ⚠️
...er/graph_builder/module/osm/ElevatorProcessor.java 83.33% 1 Missing ⚠️
...ripplanner/graph_builder/module/osm/OsmModule.java 90.00% 0 Missing and 1 partial ⚠️
...nner/graph_builder/module/osm/UnconnectedArea.java 0.00% 1 Missing ⚠️
.../graph_builder/module/osm/WalkableAreaBuilder.java 94.44% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6131      +/-   ##
=============================================
- Coverage      69.85%   69.85%   -0.01%     
  Complexity     17494    17494              
=============================================
  Files           1976     1976              
  Lines          74705    74705              
  Branches        7643     7643              
=============================================
- Hits           52188    52185       -3     
- Misses         19868    19870       +2     
- Partials        2649     2650       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optionsome
Copy link
Member

AreaGroup#getSomeOSMObject
OsmProvider#readOSM
OsmModule has variable segmentStartOSMNode
TurnRestrictionTag has variable relationOSMID
UnconnectedAreasTest#buildOSMGraph
OsmOpeningHoursParserTest#testOSMOpeningHoursParsing
GraphBuilderModules#provideOpenStreetMapModule

We also generate issue store entry with name "OSMOpeningHoursUnparsed"

@optionsome
Copy link
Member

There are conflicts now

vpaturet
vpaturet previously approved these changes Oct 9, 2024
@leonardehrenfried leonardehrenfried merged commit 8b2ee3b into opentripplanner:dev-2.x Oct 9, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 9, 2024
@leonardehrenfried leonardehrenfried deleted the osm-naming branch October 9, 2024 15:04
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants