Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector tiles: style parallel edges #6134

Conversation

flaktack
Copy link
Contributor

@flaktack flaktack commented Oct 9, 2024

Summary

The vector tile shows the edges, but the forward/backward edges overlap. A line-offset of half the line width is added to the style, so the directions are separated:
image

The style offsets the edges so that the directions may be
differentiated.
@flaktack flaktack requested a review from a team as a code owner October 9, 2024 14:13
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.86%. Comparing base (07c72ea) to head (b7563d6).
Report is 5 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6134   +/-   ##
==========================================
  Coverage      69.85%   69.86%           
+ Complexity     17497    17494    -3     
==========================================
  Files           1976     1976           
  Lines          74710    74711    +1     
  Branches        7645     7643    -2     
==========================================
+ Hits           52191    52194    +3     
+ Misses         19868    19867    -1     
+ Partials        2651     2650    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingly simple!

@leonardehrenfried leonardehrenfried merged commit d95ffa3 into opentripplanner:dev-2.x Oct 9, 2024
5 checks passed
@flaktack flaktack deleted the feature/inspector-tiles-directions branch October 11, 2024 14:29
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants