Add @Nullable annotations to Trip and Leg #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
previously approved these changes
Oct 11, 2024
habrahamsson-skanetrafiken
force-pushed
the
nullability-leg-and-trip
branch
from
f5395c4 to
9ef34d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6147 +/- ##
=============================================
+ Coverage 69.90% 69.93% +0.02%
- Complexity 17709 17727 +18
=============================================
Files 1996 1996
Lines 75328 75401 +73
Branches 7713 7717 +4
=============================================
+ Hits 52659 52729 +70
- Misses 19992 19995 +3
Partials 2677 2677 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
previously approved these changes
Oct 11, 2024
habrahamsson-skanetrafiken
force-pushed
the
nullability-leg-and-trip
branch
from
9ef34d1 to
6c37596
Compare
|
I rebased because of the maven modules change |
|
Can you rebase again? The docs installation issue is fixed on dev-2.x. |
habrahamsson-skanetrafiken
force-pushed
the
nullability-leg-and-trip
branch
from
6c37596 to
b992e36
Compare
| @@ -178,7 +179,7 @@ public void validateLeg( | |||
| assertEquals(1, leg.getStreetNotes().size()); | |||
| assertEquals(alert, leg.getStreetNotes().iterator().next().note.toString()); | |||
| } else { | |||
| assertNull(leg.getStreetNotes()); | |||
| Truth.assertThat(leg.getStreetNotes()).isEmpty(); | |||
There was a problem hiding this comment.
Suggested change
| Truth.assertThat(leg.getStreetNotes()).isEmpty(); | |
| assertThat(leg.getStreetNotes()).isEmpty(); |
There was a problem hiding this comment.
Now it is!
leonardehrenfried
approved these changes
Oct 17, 2024
optionsome
approved these changes
Oct 21, 2024
habrahamsson-skanetrafiken
merged commit db240e9
into
opentripplanner:dev-2.x
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
@Nullableannotiation to stuff that can be null inTripandLeg. Also reorder the fields in Trip to be more in order of importance.Issue
#6048
Unit tests
No tests
Bumping the serialization version id
The fields in
Tripare reordered, but this should not change serialization.