Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency eslint-plugin-react-hooks to v5 #6159

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 15, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-react-hooks (source) 4.6.2 -> 5.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

facebook/react (eslint-plugin-react-hooks)

v5.0.0

Compare Source

  • New Violations: Component names now need to start with an uppercase letter instead of a non-lowercase letter. This means _Button or _component are no longer valid. (@​kassens) in #​25162

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner October 15, 2024 13:05
@renovate renovate bot requested a review from testower October 15, 2024 13:05
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (6b3ba97) to head (acc1f07).
Report is 20 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6159      +/-   ##
=============================================
- Coverage      69.90%   69.90%   -0.01%     
+ Complexity     17711    17708       -3     
=============================================
  Files           1996     1996              
  Lines          75328    75328              
  Branches        7713     7713              
=============================================
- Hits           52660    52658       -2     
- Misses         19992    19993       +1     
- Partials        2676     2677       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

renovate bot commented Oct 15, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
@testower
Copy link
Contributor

@leonardehrenfried Generally, it's better to keep non-related changes out of renovate PRs, but I'll approve it this time :)

@leonardehrenfried
Copy link
Member

Since so many PRs started failing because of this, I also made the fix on dev-2.x: 86e580f

I'm not sure if this makes it better or worse. :|

@leonardehrenfried leonardehrenfried merged commit 8355646 into dev-2.x Oct 16, 2024
6 checks passed
@leonardehrenfried leonardehrenfried deleted the renovate/major-react-monorepo branch October 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants