Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Java source files from protocol buffer definition files in separate Maven module #6184

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Oct 21, 2024

Summary

Generating the GTFS Realtime Protobuf files in a separate module has several advatags:

  • The config is clear (what config apply this module) - pom.xml
  • Speed up builds - this does not need to build every time

Issue

Part of #6155

Unit tests

No

Documentation

No

Changelog

No

Bumping the serialization version id

No

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 21, 2024
@t2gran t2gran requested a review from a team as a code owner October 21, 2024 22:43
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.92%. Comparing base (0ae34a8) to head (d562a52).

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6184   +/-   ##
==========================================
  Coverage      69.92%   69.92%           
+ Complexity     17736    17735    -1     
==========================================
  Files           1998     1998           
  Lines          75419    75419           
  Branches        7718     7718           
==========================================
  Hits           52737    52737           
+ Misses         20004    20003    -1     
- Partials        2678     2679    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t2gran t2gran force-pushed the otp2_gtfs_realtime_proto branch from dae1e2d to d562a52 Compare October 21, 2024 22:51
@abyrd
Copy link
Member

abyrd commented Oct 23, 2024

Based on comments in the diff, this PR seems to be about using gtfs-realtime-protobuf to "compile the gtfs-realtime.proto file to Java code". Can I update the title and description of the PR to reflect this? It currently says it's generating protobuf files, which caused me some confusion when first approaching it.

@abyrd
Copy link
Member

abyrd commented Oct 23, 2024

Can this section in the top-level POM be moved into the submodule?

 <build>
        <extensions>
            <!-- makes build variables like os.detected.classifier available.
                 use to select the correct protoc instance for the OS.
                 see protobuf-maven-plugin below -->
            <extension>
                <groupId>kr.motd.maven</groupId>
                <artifactId>os-maven-plugin</artifactId>
                <version>1.7.1</version>
            </extension>
        </extensions>
...
</build>

@t2gran t2gran changed the title Generate GTFS Realtime protobuf files in separate Maven module Generate Java source files from protocol buffer definition files in separate Maven module Oct 24, 2024
@t2gran t2gran merged commit d78f547 into opentripplanner:dev-2.x Oct 24, 2024
5 checks passed
@t2gran t2gran deleted the otp2_gtfs_realtime_proto branch October 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants