Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide transfer URLs from Maven CI logs, upload test data to codecov #6220

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Nov 4, 2024

Summary

Whenever I need to look at a CI log, I have to scroll past a very long list of URLs that Maven has downloaded and I never had any use from these at all.

For this reason I'm proposing to completely hide these URLs from the CI log.

On top of this, the PR also enables colour output for the CI logs and adds some Unicode characters.

It looks like this:

image

Coverage data aggregation

I also removed the hardcoded path to the coverage file and I hope that this will automatically lead to sub-module's coverage data being discovered.

Test data uploads

Codecov has a new feature where they allow you to upload test data, which I want to try out. It's doesn't work out of the box with JUnit yet, but I'm working on it: codecov/feedback#304 (comment)

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner November 4, 2024 07:27
@leonardehrenfried leonardehrenfried changed the title Hide transfer logs from Maven CI log Hide transfer URLs from Maven CI logs Nov 4, 2024
@leonardehrenfried leonardehrenfried changed the title Hide transfer URLs from Maven CI logs Hide transfer URLs from Maven CI logs, aggregate coverage reports from modules Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (507baef) to head (9063f93).
Report is 88 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6220   +/-   ##
==========================================
  Coverage      69.92%   69.93%           
- Complexity     17730    17733    +3     
==========================================
  Files           2000     2000           
  Lines          75487    75487           
  Branches        7727     7727           
==========================================
+ Hits           52787    52793    +6     
+ Misses         20015    20011    -4     
+ Partials        2685     2683    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried changed the title Hide transfer URLs from Maven CI logs, aggregate coverage reports from modules Hide transfer URLs from Maven CI logs, upload test data to codecov Nov 4, 2024
@leonardehrenfried leonardehrenfried merged commit 87b6a46 into opentripplanner:dev-2.x Nov 7, 2024
5 checks passed
@leonardehrenfried leonardehrenfried deleted the mvn-transfer-log branch November 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants