-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide transfer URLs from Maven CI logs, upload test data to codecov #6220
Merged
leonardehrenfried
merged 10 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:mvn-transfer-log
Nov 7, 2024
Merged
Hide transfer URLs from Maven CI logs, upload test data to codecov #6220
leonardehrenfried
merged 10 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:mvn-transfer-log
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
changed the title
Hide transfer logs from Maven CI log
Hide transfer URLs from Maven CI logs
Nov 4, 2024
leonardehrenfried
changed the title
Hide transfer URLs from Maven CI logs
Hide transfer URLs from Maven CI logs, aggregate coverage reports from modules
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6220 +/- ##
==========================================
Coverage 69.92% 69.93%
- Complexity 17730 17733 +3
==========================================
Files 2000 2000
Lines 75487 75487
Branches 7727 7727
==========================================
+ Hits 52787 52793 +6
+ Misses 20015 20011 -4
+ Partials 2685 2683 -2 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
mvn-transfer-log
branch
from
November 4, 2024 09:18
85fc20c
to
8f56db7
Compare
leonardehrenfried
force-pushed
the
mvn-transfer-log
branch
from
November 4, 2024 13:50
27c1438
to
8c81240
Compare
# Conflicts: # .github/workflows/cibuild.yml
leonardehrenfried
force-pushed
the
mvn-transfer-log
branch
from
November 4, 2024 17:01
8c81240
to
28fbcf1
Compare
leonardehrenfried
changed the title
Hide transfer URLs from Maven CI logs, aggregate coverage reports from modules
Hide transfer URLs from Maven CI logs, upload test data to codecov
Nov 4, 2024
habrahamsson-skanetrafiken
requested review from
habrahamsson-skanetrafiken and
t2gran
November 5, 2024 10:57
t2gran
approved these changes
Nov 6, 2024
habrahamsson-skanetrafiken
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Whenever I need to look at a CI log, I have to scroll past a very long list of URLs that Maven has downloaded and I never had any use from these at all.
For this reason I'm proposing to completely hide these URLs from the CI log.
On top of this, the PR also enables colour output for the CI logs and adds some Unicode characters.
It looks like this:
Coverage data aggregation
I also removed the hardcoded path to the coverage file and I hope that this will automatically lead to sub-module's coverage data being discovered.
Test data uploads
Codecov has a new feature where they allow you to upload test data, which I want to try out. It's doesn't work out of the box with JUnit yet, but I'm working on it: codecov/feedback#304 (comment)