Portland test graph: calculate transfers between stops #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6237 +/- ##
=============================================
- Coverage 69.91% 69.75% -0.16%
+ Complexity 17736 17661 -75
=============================================
Files 2006 2007 +1
Lines 75526 75573 +47
Branches 7730 7734 +4
=============================================
- Hits 52804 52718 -86
- Misses 20036 20141 +105
- Partials 2686 2714 +28 ☔ View full report in Codecov by Sentry. |
| new DirectTransferGenerator( | ||
| graph, | ||
| timetableRepository, | ||
| new DefaultDataImportIssueStore(), |
There was a problem hiding this comment.
No that I would make a huge difference but I think we want the NOOP implementation here
There was a problem hiding this comment.
Thanks, I've updated it to use the NOOP implementation.
flaktack
force-pushed
the
feature/portland-transfers
branch
from
1189d72 to
2bd6d5e
Compare
leonardehrenfried
approved these changes
Nov 8, 2024
t2gran
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Portland graph used for snapshot tests was missing generated transfers between stops: this updates the graph building process to use
DirectTransferGenerator.