Rename 'bogusName' to 'nameIsDerived' #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
requested review from
abyrd and
habrahamsson-skanetrafiken
leonardehrenfried
force-pushed
the
bogus-name
branch
from
d42d330 to
4c6db7f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6333 +/- ##
=============================================
- Coverage 69.82% 69.81% -0.01%
+ Complexity 17830 17828 -2
=============================================
Files 2021 2021
Lines 76250 76250
Branches 7802 7802
=============================================
- Hits 53238 53237 -1
- Misses 20297 20298 +1
Partials 2715 2715 ☔ View full report in Codecov by Sentry. |
abyrd
approved these changes
Dec 13, 2024
habrahamsson-skanetrafiken
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a follow-up to my previous bogus name PR, this renames the internal uses of "has bogus name" to "name is derived".
@abyrd @habrahamsson-skanetrafiken I've taken the liberty to ask for your review. This is absolutely low priority but let me know if you don't want to do it.