-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SIRI-ET and GTFS-RT TripUpates at the same time #6363
Open
leonardehrenfried
wants to merge
18
commits into
opentripplanner:dev-2.x
Choose a base branch
from
leonardehrenfried:siri-gtfs
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use SIRI-ET and GTFS-RT TripUpates at the same time #6363
leonardehrenfried
wants to merge
18
commits into
opentripplanner:dev-2.x
from
leonardehrenfried:siri-gtfs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
Technical Debt
Real-Time Update
The issue/PR is related to RealTime updates
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
labels
Jan 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6363 +/- ##
=============================================
+ Coverage 69.79% 69.80% +0.01%
+ Complexity 17943 17933 -10
=============================================
Files 2046 2046
Lines 76685 76645 -40
Branches 7829 7825 -4
=============================================
- Hits 53520 53505 -15
+ Misses 20423 20401 -22
+ Partials 2742 2739 -3 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
siri-gtfs
branch
from
January 7, 2025 17:06
f80a8a6
to
5f8eb10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Real-Time Update
The issue/PR is related to RealTime updates
Technical Debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously it was not possible to run SIRI-ET and GTFS-RT TripUpdates in the same instance. This PR changes it by cleaning up the relationships of the various real-time components.
A class diagram to show the new relationships is available in the issue #6348.
Issue
Closes #6348
Unit tests
Some unit tests updated.
Documentation
The new class diagram is available in this PR in
doc/dev/diagrams/TimetableSnapshotManager.svg
.Bumping the serialization version id
While no actual entities have changed, but the
TimetableRepository
has which is serialized into the graph. Therefore we need to bump it.cc @fahrplaner