Show nearby stops and nearby amenities in Stop Viewer #423

landonreed · 2021-07-29T19:49:11Z

This PR adds to new panels to the stop viewer according to the Sketch mocks. They contain related/nearby stops and nearby amenities.

A couple of items I'm looking for thoughts on:

how to refresh (maybe even whether to even bother refreshing) all of the related stops stop times and bike/vehicle rental locations without sending loads of requests
ideas on improving the rendering of stops on the map that serve lots of routes (maybe just using an ellipsis after a certain length).

… childstop ids

…i ready to style - phase 1 #412

#412

…a child stops. #412

…/github.com/opentripplanner/otp-react-redux into show-child-stops-with-routes-in-stop-viewer

… issues

lib/reducers/create-otp-reducer.js

lib/util/viewer.js

lib/components/viewers/stop-time-cell.js

lib/actions/ui.js

lib/components/viewers/related-panel.js

lib/actions/api.js

lib/components/viewers/stop-viewer.js

lib/components/viewers/related-stops-panel.js

miles-grant-ibigroup · 2021-10-14T09:50:15Z

@philip-cline I've added internationalization to all new strings (assuming that things like the stop viewer are covered by other i18n PRs). One thing I didn't know how to do that I hope you'll be able to help with is pluralization. I've added a FIXME to every relevant string.

Once that is resolved we should be ready to merge with your approval! Then I will assign the updated stop viewer bubbles to you.

philip-cline

Added pluralisation and left one quick comment. Otherwise LGTM!

i18n/en-US.yml

miles-grant-ibigroup · 2021-10-15T09:03:52Z

@philip-cline going to assign back to you one last time to make sure that the the bikes capitalization commit looks good, but if it does please feel free to merge!

github-actions · 2021-10-21T13:06:45Z

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

robertgregg3 and others added 17 commits July 11, 2021 22:23

feat(stop-viewer.js): Rendering list of Stop IDs

1d06ccb

improvement(child-stop-viewer.js): Abstracted component to render the…

5dde8db

… childstop ids

feat(child-stop-details.js): Created basic template with data from ap…

57cb055

…i ready to style - phase 1 #412

fix(child-stop-details.js): Fixed flow errors

062f164

#412

improvement(child-stop-details.js): Added a toggle to expand the extr…

a9d0c55

…a child stops. #412

refactor(child-stop-details.js): Refactored CSS, removed console logs

d69c495

refactor(child-stop-viewer.js): Forgot to save/commit the api file

e4b7381

Merge branch 'dev' into show-child-stops-with-routes-in-stop-viewer

c2acf8a

refactor(child-stop-details.js): Fixed flow issues and removed some css.

5f06fe3

Merge branch 'show-child-stops-with-routes-in-stop-viewer' of https:/…

9b925ea

…/github.com/opentripplanner/otp-react-redux into show-child-stops-with-routes-in-stop-viewer

improvement(api.js): Reordered arguments and properties to fix eslint…

45d8b8b

… issues

improvement(stop-viewer.js): Reordered properties to fix eslint issues

557f01f

improvement(stop-viewer.js): Updated the stop-viewer tests

7ff6935

refactor(stop-viewer): reorganize child stops component

88416ee

refactor(stop-viewer): refactor into related panels

8bbc90c

feat(stop-viewer): add nearby amenities panel

5d2cbd4

test: update snaps

8d5ff6a

landonreed assigned evansiroky Jul 29, 2021