lint with yapf and isort #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbestigrou
reviewed
Sep 4, 2018
| import mechanicalsoup | ||
| from fake_useragent import UserAgent | ||
|
|
||
| import mechanicalsoup |
Contributor
There was a problem hiding this comment.
You don't must add a line break between fake_useragent and mechanicalsoup import.
Author
There was a problem hiding this comment.
IMHO and from isort point of view module import import <module> should be separate from sub-module import from <module> import <sub-module> by a line break, that's why this line break is added
hobbestigrou
reviewed
Sep 4, 2018
| import logging | ||
|
|
||
| from mechanicalsoup.browser import LinkNotFoundError | ||
|
|
Contributor
There was a problem hiding this comment.
You don't must remove the line break here.
Author
There was a problem hiding this comment.
I agree that current module import should be separate with by a line break from other module import, to do so and keep isort usage better explicit define current module import as local using dot syntax, in this example:
from .context_manager import login
Author
|
Here is my [isort]
sections=FUTURE,STDLIB,THIRDPARTY,DJANGO,TAIGA,WAGTAIL,ODOO,ODOOADDONS,OPENERP,OPENERPADDONS,LOCALFOLDER,UNKNOWNTHIRDPARTY
known_odoo=odoo
known_odooaddons=odoo.addons
known_openerp=openerp
known_openerpaddons=openerp.addons
known_django=django
known_taiga=taiga
known_wagtail=wagtail
default_section=UNKNOWNTHIRDPARTY
multi_line_output=3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.