UCT/GDA/TEST: Add runtime config for device debug logs #10917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
force-pushed
the
topic/uct-gda-test-add-runtime-config-for
branch
7 times, most recently
from
8fceb3f to
faa224f
Compare
yosefe
force-pushed
the
topic/uct-gda-test-add-runtime-config-for
branch
from
faa224f to
89ca917
Compare
brminich
reviewed
Oct 3, 2025
| ucp_device_request_t &req = request_mgr.get_request(); | ||
| status = ucp_perf_cuda_send_nbx<level, cmd>(params, idx, req); | ||
| if (status != UCS_OK) { | ||
| ucs_device_error("send failed: %d", status); |
There was a problem hiding this comment.
can we keep error macro for convinience?
iyastreb
reviewed
Oct 6, 2025
Comment on lines
+53
to
+62
| const char *basename = path; | ||
| const char *p; | ||
|
|
||
| for (p = path; *p != '\0'; p++) { | ||
| if (*p == '/') { | ||
| basename = p + 1; | ||
| } | ||
| } | ||
|
|
||
| return basename; |
There was a problem hiding this comment.
Maybe use standard lib:
Suggested change
| const char *basename = path; | |
| const char *p; | |
| for (p = path; *p != '\0'; p++) { | |
| if (*p == '/') { | |
| basename = p + 1; | |
| } | |
| } | |
| return basename; | |
| const char *basename = strrchr(path, '/'); | |
| return basename ? basename + 1 : path; |
|
|
||
| UCS_F_DEVICE const char *ucs_device_log_source_file(const char *file) | ||
| { | ||
| static const char *cached_source_file = NULL; |
There was a problem hiding this comment.
I'm not sure if this caching is always safe
What happens if translation unit includes a header file which contains a logger call?
Which FILE will be cached?
|
|
||
|
|
||
| /* | ||
| * Read a 64-bit atomic value from a global memory address. |
There was a problem hiding this comment.
please align all docs in this file
| * See file LICENSE for terms. | ||
| */ | ||
|
|
||
| #ifndef UCS_STUB_DEVICE_CUH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.