TEST/UCP/DEVICE: Fix device API test wireup #10938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvegas1
reviewed
Oct 7, 2025
test/gtest/ucp/test_ucp_device.cc
Outdated
| while (ucp_device_mem_list_create(sender().ep(), NULL, &handle) == | ||
| UCS_ERR_NOT_CONNECTED) { | ||
| /* Wait for endpoint to complete wireup by checking the REMOTE_CONNECTED flag */ | ||
| while (!(sender().ep()->flags & UCP_EP_FLAG_REMOTE_CONNECTED)) { |
Contributor
There was a problem hiding this comment.
if logging prevents using invalid mem list create call, maybe we can try to create a valid one/destroy, to avoid using internal flags. also that is the call being needed in the tests so it could make sense to check if it works in the first place.
Contributor
Author
There was a problem hiding this comment.
Used flush_ep() instead
michal-shalev
force-pushed
the
fix-test-ucp-device-wireup-sync
branch
from
6d229a2 to
191803f
Compare
tvegas1
reviewed
Oct 8, 2025
| progress(); | ||
| } | ||
| /* Flush to ensure endpoint wireup is complete before device API usage */ | ||
| flush_ep(sender()); |
Contributor
There was a problem hiding this comment.
i think flush can return ok even when connection has not happened, so if we use flush, we should probably send first a dummy request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix wireup issue in
test_ucp_deviceinitialization.Why?
CI is failing on #10921 which adds error logging to device APIs. The test's init() function was waiting for endpoint wireup by calling ucp_device_mem_list_create() with NULL params in a loop. This caused multiple error logs ("ep didn't complete wireup" and "check parameters failed") to be printed during normal test initialization. Without error logging these were silent, but PR #10921's improved logging now exposes these errors, causing test failures.
How?
Used flush_ep() to ensure endpoint wireup is fully complete before tests create device memory lists.