updated urls Dana Farber Repository #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskandr
approved these changes
Sep 1, 2017
pepdata/danafarber.py
Outdated
| if hla_type: | ||
| mask &= df.Allele.str.contains(hla_type) | ||
| if source_protein: | ||
| mask &= df.Protein.str.contains(source_protein) | ||
| mask &= df["Tumor antigen"].str.contains(source_protein) |
There was a problem hiding this comment.
This feels like a dumb question, but is that whitespace before mask correct?
There was a problem hiding this comment.
not a dumb question at all and yes that was whitespace. I removed and amended the commit.
… Changing df column names from Peptide to Epitope. Removing whitespace typo.
|
Hey @davidballi -- can you say more about how you're using the library? I'm working on a PR that gets rid of all the datasets except IEDB and focuses more on amino acid properties / features. Would that interfere with your work? |
|
Hi @iskandr. We are using the library for the interface with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes for danafarber.py
subdiroption on my machine. removed from function call.This change is