Skip to content

[FORK][FIX] Restore choose_loop_order logic for weights decompression case #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.3_for_ie_master
Choose a base branch
from
Open

[FORK][FIX] Restore choose_loop_order logic for weights decompression case #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cpu/x64/jit_brgemm_inner_product_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,7 +1885,8 @@ void jit_brgemm_ip_fwd_conf_t::choose_loop_order() {
const bool is_int8 = one_of(src_dt, u8, s8) && wei_dt == s8;
const bool is_compute_amx = (is_xf16 || is_int8) && is_amx;

if ((os_block < 32 || do_occ_osc) && (is_compute_amx || is_f32_avx2))
// Better to keep ocb loop outermost for weights_decompression case due to overhead on weights unpack into intermediate buffer
if ((os_block < 32 || do_occ_osc) && (is_compute_amx || is_f32_avx2) && !weights_decompression)
loop_order = icc_occ_osc_ocb_osb;
}

Expand Down