Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Add GenAI Node.js bindings #1193
base: master
Are you sure you want to change the base?
[JS] Add GenAI Node.js bindings #1193
Changes from 62 commits
0d73757
2d71b6b
0c0b41c
7e80306
67d5a40
689e352
4e3405a
6853446
e433a19
ae806da
8632882
9ceb3b5
599713b
222940d
901dd90
09356ef
96d53b2
785bf8d
e8c53f2
82ae75f
963fc1d
1d952b6
e909f03
c5f5f85
6d7cbcd
d999569
4479e1b
b722d39
3b4b3c0
17f2069
27a97d8
b3eba5e
6f0e0b4
855c893
df51af9
a365ef8
6d0b501
f241cda
1e97e70
1f2324b
dda494d
394d425
3186142
2fbd888
2daa0f3
0a0c399
35c1c61
b2cb5dd
13c0558
432e3de
30803b4
b04ee6c
d7e0d2b
d1ce555
ea0ff4a
7f8ee36
6434daf
d03b5cd
f9d720b
6d36185
2215590
82881ba
a1cdda0
4a63106
02b28ca
ea69261
5c00a91
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, rename chat_sample folder to text_generation.
See #1411 where we move all samples from the same category to a single folder.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to use js bindings from build tree directly? If not, you should enforce
NPM
package generator ifENABLE_JS
is true.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try, but I am not sure about this change.
Because, there is the reason why it keeps separately.
CPACK_GENERATOR
is responsible to put all files in the appropriate structure. In the binaries archive for nodejs package we must have flat structure with all libs at the top level.But
ENABLE_JS
option is responsible for producinggenai_node_addon.node
library. If we look at the build logs of openvino we can see thatENABLE_JS
is ON even general package build. It means if we forceCPACK_GENERATOR = NPM
option ifENABLE_JS
is ON we will break existed build setup.@ilya-lavrenov, could you suggest the optimal way to handle this behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like if we follow @Wovchena we will not break anything for GenAI specifically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples => development files