StaticLLMPipeline: Support more generation options #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…genai into at/static-llm-pipeline-advanced-sampling
github-actions
bot
added
category: LLM
TolyaTalamanov
changed the title
|
why not to re-use the whole Sampler? Limited to cases when we don't need to fork sequences (like in beam search) |
Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
sbalandi
reviewed
Jan 2, 2025
| @@ -227,7 +227,6 @@ def run_text_generation_genai(input_text, num, model, tokenizer, args, iter_data | |||
| gen_config = model.get_generation_config() | |||
| gen_config.max_new_tokens = max_gen_tokens | |||
| gen_config.num_beams = args["num_beams"] | |||
There was a problem hiding this comment.
please, remove set_seed(args['seed']) on str 201 and 356 and add gen_config.rng_seed= args["seed"] here and to run_text_generation_genai_with_stream
There was a problem hiding this comment.
Done, thanks!
sbalandi
approved these changes
Jan 2, 2025
ilya-lavrenov
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.