Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LoRA support to CB, SD, PL #1452

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Added LoRA support to CB, SD, PL #1452

merged 1 commit into from
Dec 30, 2024

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Dec 30, 2024 •
edited
Loading

CVS-159960

@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Dec 30, 2024
@ilya-lavrenov ilya-lavrenov self-assigned this Dec 30, 2024
@github-actions github-actions bot added category: continuous batching Continuous batching category: LLM LLM pipeline (stateful, static) category: speculative decoding Speculative decoding category: LoRA Low rank adapters category: cmake / build Cmake scripts category: GenAI C++ API Changes in GenAI C++ public headers no-match-files category: prompt lookup labels Dec 30, 2024
sbalandi
sbalandi approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@sbalandi sbalandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilya-lavrenov ilya-lavrenov merged commit ba0224f into openvinotoolkit:master Dec 30, 2024
59 checks passed
@ilya-lavrenov ilya-lavrenov deleted the cb-lora branch December 30, 2024 11:37
as-suvorov
as-suvorov reviewed Dec 30, 2024
View reviewed changes
src/cpp/src/continuous_batching_impl.cpp
@@ -183,6 +201,7 @@ void ContinuousBatchingPipeline::ContinuousBatchingImpl::step() {
step_count++;
#endif

// process generation_config.echo parameetr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// process generation_config.echo parameetr
// process generation_config.echo parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as-suvorov as-suvorov as-suvorov left review comments

@sbalandi sbalandi sbalandi approved these changes

Assignees

@as-suvorov as-suvorov

@sbalandi sbalandi

Labels
category: cmake / build Cmake scripts category: continuous batching Continuous batching category: GenAI C++ API Changes in GenAI C++ public headers category: LLM LLM pipeline (stateful, static) category: LoRA Low rank adapters category: prompt lookup category: speculative decoding Speculative decoding no-match-files
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ilya-lavrenov @as-suvorov @sbalandi