[LLM][NPU] Ported sampler from Stateless to Stateful pipeline #1507
+48
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AsyaPronina
commented
Jan 8, 2025
AsyaPronina
commented
- Ported sampler functionality from Stateless to Stateful pipeline
| if (streamer_ptr && streamer_ptr->put(last_token)) { | ||
| return results; | ||
| } | ||
| // Swap max_new_token to get_max_new_token() |
There was a problem hiding this comment.
is this comment is valid? here we don't play with max_new_tokens
There was a problem hiding this comment.
No, not valid, sorry
| // Swap max_new_token to get_max_new_token() | ||
| auto sequence_group = std::make_shared<SequenceGroup>( | ||
| 0 /* request_id */, input_ids, config, 1 /* block_size */); | ||
| sequence_group->update_processed_tokens_num(input_ids.get_size()); |
There was a problem hiding this comment.
Suggested change
| sequence_group->update_processed_tokens_num(input_ids.get_size()); | |
| sequence_group->update_processed_tokens_num(sequence_group->get_prompt_len() - output_sequence_len); |
There was a problem hiding this comment.
Will it work w/o SLICE_OUT?
There was a problem hiding this comment.
I suppose yes.
w/o Slice output len is the same as prompt len and, hence, number of processed tokens is 0
There was a problem hiding this comment.
I agree, however, for first input_ids we have length == length of prompt, for example, 18. But output_sequence_len is equal to 1024 for first logits as it is output from prefill model.
ilya-lavrenov
changed the title
| // Swap max_new_token to get_max_new_token() | ||
| auto sequence_group = std::make_shared<SequenceGroup>( | ||
| 0 /* request_id */, input_ids, config, 1 /* block_size */); | ||
| sequence_group->update_processed_tokens_num(input_ids.get_size()); |
There was a problem hiding this comment.
Will it work w/o SLICE_OUT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.