add max_lengh parametrisation to encode #1518
Draft
+97
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: tokenizers
| return {std::numeric_limits<int32_t>::max(), std::numeric_limits<int32_t>::max()}; | ||
| } else if (padding_mode == "max_length") { | ||
| return {std::numeric_limits<int32_t>::max(), max_length}; | ||
| } else if (padding_mode == "do_not_pad") { |
There was a problem hiding this comment.
why is string, but not enum?
| } else if (padding_mode == "max_length") { | ||
| return {std::numeric_limits<int32_t>::max(), max_length}; | ||
| } else if (padding_mode == "do_not_pad") { | ||
| // bahves exactly as longest |
There was a problem hiding this comment.
Suggested change
| // bahves exactly as longest | |
| // behaves exactly as longest |
| # Calling encode with 'add_special_tokens' will set state flag. | ||
| ov_res = genai_tokenzier.encode(prompt, add_special_tokens=add_special_tokens, max_length=max_length, padding_mode=pad_mode).input_ids.data | ||
| hf_res = hf_tokenizer(prompt, return_tensors="np", add_special_tokens=add_special_tokens, max_length=max_length, padding=pad_mode)["input_ids"] | ||
| assert np.all(ov_res == hf_res) |
There was a problem hiding this comment.
do we need to test attention mask as well?
is attention_mask's tail filled with zeros in case of padding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works in collaboration with tokenizers changes openvinotoolkit/openvino_tokenizers#362
Ticket: CVS-157356