Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples readme #1545

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

olpipi
Copy link
Collaborator

@olpipi olpipi commented Jan 14, 2025

Apply the rest comments from #1411

samples/cpp/text_generation/README.md Outdated Show resolved Hide resolved

## Sample Descriptions
### Common information
Follow [Get Started with Samples](https://docs.openvino.ai/2024/learn-openvino/openvino-samples/get-started-demos.html) to get common information about OpenVINO samples.
Follow [build instruction](https://github.com/openvinotoolkit/openvino.genai/blob/master/src/docs/BUILD.md) to build GenAI samples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced instructions describe how to build the whole package. They should be extended to describe how to build samples only from OpenVINO archive

Copy link
Collaborator Author

@olpipi olpipi Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole genai build includes samples. They cannot be built separately now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenVINO archive

OpenVINO archive is not enough to build GenAI samples.

Do you mean build samples when you download OpenVINO GenAI and re-use samples source from the samples folder?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build samples from the OV archive only. https://medium.com/openvino-toolkit/how-to-build-openvino-genai-app-in-c-32dcbe42fa67
Samples (samples folder) are included in the archive as well.
I see that build script is still in place in the archive.
Build samples from archive is more convenient for developer as build whole openvino genai from source when only samples are needed, require a lot of time.
Therefore adding section to build instruction how to build samples from archive will be helpful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openvino_genai_windows_2024.3.0.0_x86_64

is genai package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey, with OpenVINO Archive (as it is called in selector tool) I meant OpenVINO GenAI Archive.
image

Copy link
Collaborator Author

@olpipi olpipi Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CVS-160869 - task to update build manual

samples/cpp/text_generation/README.md Outdated Show resolved Hide resolved
samples/cpp/text_generation/README.md Outdated Show resolved Hide resolved
samples/python/text_generation/README.md Outdated Show resolved Hide resolved
samples/python/text_generation/README.md Outdated Show resolved Hide resolved
samples/python/text_generation/README.md Outdated Show resolved Hide resolved
@olpipi olpipi requested a review from ilya-lavrenov January 20, 2025 13:46
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Jan 21, 2025
@ilya-lavrenov
Copy link
Contributor

Please, port to releases/2025/0.

Merged via the queue into openvinotoolkit:master with commit 2dab07b Jan 21, 2025
59 checks passed
olpipi added a commit to olpipi/openvino.genai that referenced this pull request Jan 21, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants