-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples readme #1545
Update samples readme #1545
Conversation
|
||
## Sample Descriptions | ||
### Common information | ||
Follow [Get Started with Samples](https://docs.openvino.ai/2024/learn-openvino/openvino-samples/get-started-demos.html) to get common information about OpenVINO samples. | ||
Follow [build instruction](https://github.com/openvinotoolkit/openvino.genai/blob/master/src/docs/BUILD.md) to build GenAI samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The referenced instructions describe how to build the whole package. They should be extended to describe how to build samples only from OpenVINO archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whole genai build includes samples. They cannot be built separately now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenVINO archive
OpenVINO archive is not enough to build GenAI samples.
Do you mean build samples when you download OpenVINO GenAI and re-use samples source from the samples
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build samples from the OV archive only. https://medium.com/openvino-toolkit/how-to-build-openvino-genai-app-in-c-32dcbe42fa67
Samples (samples folder) are included in the archive as well.
I see that build script is still in place in the archive.
Build samples from archive is more convenient for developer as build whole openvino genai from source when only samples are needed, require a lot of time.
Therefore adding section to build instruction how to build samples from archive will be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openvino_genai_windows_2024.3.0.0_x86_64
is genai package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CVS-160869 - task to update build manual
Please, port to releases/2025/0. |
Apply the rest comments from openvinotoolkit#1411
Apply the rest comments from #1411