Improve readability #167
Merged
Improve readability #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Wovchena
commented
Jan 19, 2024
Wovchena
commented
- stable_diffusion_1_5: return EXIT_FAILURE to stay consistent with the rest of main()
- causal_lm 1. process()->select_next_tokens(). Although transformers name it process(), I believe select_next_tokens() is more verbose 2. return different values for different errors
1. stable_diffusion_1_5: return EXIT_FAILURE to stay consistent with the rest of main()
2. causal_lm
1. process()->select_next_tokens(). Although transformers name it process(), I believe select_next_tokens() is more verbose
2. return different values for different errors
.github/workflows/causal_lm_cpp.yml
Outdated
| @@ -33,7 +33,7 @@ jobs: | |||
| - name: Install OpenVINO | |||
| run: | | |||
| mkdir ./ov/ | |||
| curl https://storage.openvinotoolkit.org/repositories/openvino/packages/nightly/2023.3.0-13739-294cc6668c4/l_openvino_toolkit_ubuntu20_2023.3.0.dev20231219_x86_64.tgz | tar --directory ./ov/ --strip-components 1 -xz | |||
| curl https://storage.openvinotoolkit.org/repositories/openvino/packages/nightly/2024.0.0-14049-0dc2dc5f602/l_openvino_toolkit_ubuntu20_2024.0.0.dev20240118_x86_64.tgz | tar --directory ./ov/ --strip-components 1 -xz | |||
There was a problem hiding this comment.
is it supposed to return back to 2023.3 once official release is out?
There was a problem hiding this comment.
I don't have objections to set 23.3 back. The problem is that there's no longer nightly 23.3
There was a problem hiding this comment.
- we are on releases/2023/3 branch, so it's expected to test against corresponding release
- current nightly release will be removed in future as well and you will have to update it one more time.
ilya-lavrenov
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.