Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install and build instructions, refactor docs structure #485

Merged

Conversation

yatarkan
Copy link
Contributor

Previous PR for comments reference: pavel-esir#22

@yatarkan yatarkan requested a review from Wovchena June 10, 2024 14:39
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/docs/BUILD.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support much more models.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we drop main content from this file, we will have almost empty page on pypi.
is it OK?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But the links should be updated to refer to https://github.com/openvinotoolkit/openvino.genai

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this README describes repo, not package

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doesn't seem like that to me. Anyway, what should this file contain?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/docs/BUILD.md Outdated Show resolved Hide resolved
src/docs/USAGE.md Outdated Show resolved Hide resolved
src/docs/USAGE.md Outdated Show resolved Hide resolved
src/docs/USAGE.md Outdated Show resolved Hide resolved
src/docs/USAGE.md Outdated Show resolved Hide resolved
src/docs/SUPPORTED_MODELS.md Outdated Show resolved Hide resolved
src/docs/BUILD.md Outdated Show resolved Hide resolved
src/docs/BUILD.md Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
@yatarkan yatarkan marked this pull request as ready for review June 13, 2024 09:37
src/docs/HOW_IT_WORKS.md Outdated Show resolved Hide resolved
Co-authored-by: Zlobin Vladimir <vladimir.zlobin@intel.com>
@Wovchena Wovchena merged commit 9633e47 into openvinotoolkit:releases/2024/2 Jun 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants