[PyOV] Adjust wheel building for free threaded Python #32422
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
github-actions
bot
added
category: build
p-wysocki
commented
Oct 16, 2025
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
…cki/openvino into free_threaded_adjustments Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
|
We also set python version in this function openvino/cmake/developer_package/packaging/packaging.cmake Lines 139 to 140 in 4167070 |
almilosz
reviewed
Oct 16, 2025
| RESULT_VARIABLE pyversion_result | ||
| ) | ||
| if(NOT pyversion OR pyversion_result) | ||
| # Python3_VERSION_MAJOR and Python3_VERSION_MINOR are defined inside pybind11 |
There was a problem hiding this comment.
CMake’s built-in FindPython3 module sets Python3_VERSION_MAJOR
"defined by CMake's FindPython3" is better
| macro(ov_define_setup_py_packaging_vars) | ||
| # Python3_VERSION_MAJOR and Python3_VERSION_MINOR are defined inside pybind11 | ||
| set(pyversion python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}) | ||
| set(pyversion_script " |
There was a problem hiding this comment.
To consider extracting this piece of code like in ov_get_pyversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
3.14and3.14tare treated as the same thing, sincetis ignored. This PR fixes that.execute_process, but the alternative is using pybind'sPython3_SOABI, which holds a string likecpython-314t-x86_64-linux-gnu, which forces usage of regex and string manipulations.Tickets: