[CPU][core] Remove OV_CPU_NODE_SCOPED_TASK* macros, reuse existing handles in Node::execute tracing #33032
+14
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
aobolensk
force-pushed
the
itt-optimize-handles
branch
2 times, most recently
from
c50c120 to
d647c30
Compare
…ndles in Node::execute tracing
src/plugins/intel_cpu/src/node.cpp
Outdated
|
|
||
| void Node::execute(const dnnl::stream& strm, int numaId) { | ||
| OV_CPU_NODE_SCOPED_TASK_BASE(getTypeStr()); | ||
| OV_ITT_SCOPED_TASK_BASE(itt::domains::ov_intel_cpu, profiling.execute); |
Contributor
There was a problem hiding this comment.
Shouldn't we initialize profiling.execute with a type instead of a name?
I guess we can also just bring back original logic of the macro VERBOSE_PERF_DUMP_ITT_DEBUG_LOG, which did use profiling.execute.
And just drop this one completely
Contributor
Author
There was a problem hiding this comment.
Addressed, please, check
aobolensk
force-pushed
the
itt-optimize-handles
branch
from
460fa30 to
943a49f
Compare
praasz
reviewed
Nov 27, 2025
aobolensk
requested review from
EgorDuplensky and
praasz
and removed request for
EgorDuplensky
praasz
approved these changes
Nov 27, 2025
Contributor
|
@EgorDuplensky have a look, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
OV_CPU_NODE_SCOPED_TASK*macros creation of which could be avoidedexecuteITT handle fromPerfCountersclass in CPU graph node to traceNode::executeTickets: