Support fs::path in register_plugin(s) & Core(xml_file_path) #33043
Conversation
github-actions
bot
added
category: inference
| */ | ||
| void register_plugin(const std::string& plugin, const std::string& device_name, const ov::AnyMap& config = {}); | ||
|
|
||
| /** |
There was a problem hiding this comment.
There is no need to duplicate comment it can be shared with previous version
There was a problem hiding this comment.
I added brief descriptions. Methods without comments didn't appear in our documentation e.g. :
openvino/src/inference/include/openvino/runtime/core.hpp
Lines 113 to 114 in 8b4f28e
There was a problem hiding this comment.
There is like:
@{
@}
To group same functions with same description
There was a problem hiding this comment.
Looks like it's broken in our documentation. It is shown as Unnamed Group https://docs.openvino.ai/2025/api/c_cpp_api/classov_1_1_core.html#_CPPv4NK2ov4Core10read_modelERKNSt6stringERKNSt6stringERKN2ov6AnyMapE and the signature of auto read_model(const Path& model_path, is not visible
| } | ||
|
|
||
| TEST_F(CoreBaseTest, LoadPluginXMLWithFsPath) { | ||
| std::string xml_file_name = "test_plugin.xml"; |
There was a problem hiding this comment.
Why not create it as path at start and modify it?
Is better to change this test to cover some unicode case see tests
|
|
||
| std::string mock_plugin_name{"MOCK_HARDWARE_FS"}; | ||
| std::filesystem::path plugin_path = | ||
| ov::util::make_plugin_library_name(ov::test::utils::getExecutableDirectory(), |
|
|
||
| cls.def("register_plugins", | ||
| &ov::Core::register_plugins, | ||
| static_cast<void (ov::Core::*)(const std::string&)>(&ov::Core::register_plugins), |
There was a problem hiding this comment.
We should also consider how path is represented in Python API. In many places it's Union[str, bytes, pathlib.Path]
2 participants
Details:
std::filesystem::pathTickets: