Skip to content

Correct use Tensor::data() for model inputs when read-only tensors #33120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
praasz wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Correct use Tensor::data() for model inputs when read-only tensors #33120

praasz wants to merge 13 commits into from
+187 −47

Conversation

@praasz
Copy link
Contributor

@praasz praasz commented Dec 4, 2025 •
edited
Loading

Details:

  • The tensor can be created as read-only view when input pointer is constant. This kind of tensor can be used as model inputs as model input should be read-only. There is issue to use data() if input tensor is not const object the acquired pointer is not constant which throw exception to indicate that there is intention to modify of read-only tensor.
  • Update core, and plugins to convert tensor object to const when get data pointer to call correct overload
  • Update tests to use read-only tensor for inference on different devices.

Blocked PR:

Tickets:

praasz added 5 commits December 4, 2025 07:16
@praasz
Add dereference operator to ov::SoPtr
e80eaa7 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Fix using data() for model inputs in core
23d2b62 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Correct using data() for model inputs in CPU and TEMPLATE plugins
bc58426 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Correct use data() for tensors in GPU plugin
677ed0d 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Correct use data() for model inputs tensors in NPU plugin
a35b0d8 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz praasz added the WIP work in progress label Dec 4, 2025
@praasz praasz requested a review from a team as a code owner December 4, 2025 07:18
@praasz praasz requested review from a team as code owners December 4, 2025 07:18
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin category: TEMPLATE OpenVINO Template plugin category: NPU OpenVINO NPU plugin labels Dec 4, 2025
praasz added 2 commits December 4, 2025 08:57
@praasz
Apply code style
1c2c6d1 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Fix einsum ref impl
d7fa02a 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz praasz requested a review from a team as a code owner December 4, 2025 11:50
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Dec 4, 2025
@praasz praasz mentioned this pull request Dec 4, 2025
Open
@praasz
Fix Read value get input tensor
3fc04f1 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz praasz removed the WIP work in progress label Dec 4, 2025
@praasz praasz added this to the 2026.0 milestone Dec 4, 2025
olpipi
olpipi reviewed Dec 4, 2025
View reviewed changes
AlexanderKalistratov
AlexanderKalistratov reviewed Dec 5, 2025
View reviewed changes
AlexanderKalistratov
AlexanderKalistratov reviewed Dec 5, 2025
View reviewed changes
praasz added 2 commits December 5, 2025 11:03
@praasz
Add new data member in ITensor:
f5255f6 
- public interface check if tensor can write data
- ITensor::data() do not do check to be compatible with current implementation and it is for internal use

Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Revert not required changes
497cf21 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@github-actions github-actions bot added category: CPP API OpenVINO CPP API bindings and removed category: TEMPLATE OpenVINO Template plugin labels Dec 5, 2025
@praasz
Revert changes in infer request CPU
a302c9c 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
@praasz
Fix code style
b09a25e 
Signed-off-by: Pawel Raasz <pawel.raasz@intel.com>
t-jankowski
t-jankowski approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@t-jankowski t-jankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for core part

AlexanderKalistratov
AlexanderKalistratov approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@AlexanderKalistratov AlexanderKalistratov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how the issue appeared in the first place. Checks for constants were added to data() method and now it is reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pereanub pereanub pereanub approved these changes

@olpipi olpipi olpipi approved these changes

@AlexanderKalistratov AlexanderKalistratov AlexanderKalistratov approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

Assignees

No one assigned

Labels

category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: NPU OpenVINO NPU plugin

Projects

None yet

Milestone

2026.0

Development

Successfully merging this pull request may close these issues.

5 participants

@praasz @pereanub @olpipi @AlexanderKalistratov @t-jankowski