-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Remove deprecated IE output name functions from utils #33139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ons from transformation utils
| #include "itt.hpp" | ||
| #include "openvino/core/descriptor/tensor.hpp" | ||
| #include "openvino/core/graph_util.hpp" | ||
| #include "openvino/core/rt_info.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add this import? It looks like we only remove code from this file, no?
| const auto& prev_layer = result->input_value(0).get_node_shared_ptr(); | ||
| const std::string res_name = | ||
| prev_layer->get_friendly_name() + | ||
| (prev_layer->get_output_size() != 1 ? "." + std::to_string(result->input_value(0).get_index()) : ""); | ||
| fake_param->set_friendly_name(res_name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const auto& prev_layer = result->input_value(0).get_node_shared_ptr(); | |
| const std::string res_name = | |
| prev_layer->get_friendly_name() + | |
| (prev_layer->get_output_size() != 1 ? "." + std::to_string(result->input_value(0).get_index()) : ""); | |
| fake_param->set_friendly_name(res_name); | |
| fake_param->set_friendly_name(make_default_tensor_name(result->input_value(0))); |
Can be this helper be used instead?
It will use different port separator : instead of .. can be checked?
There is also util function ov::util::set_tensors_names and other which allow to set tensor names for model, can they be usefull here?
@CuriousPanCake
Is it required to set this name at all?
Details:
create_ie_output_nameandget_ie_output_namefunctions fromtransformations/utils/utils.hppicompiled_model.cpp,model_reader.cpp, andconvert_nms9_to_nms_ie_internal.cppconvert_maxpool_downgrade.cppThis change was originally implemented in #26855 but that PR was closed due to unrelated Nvidia plugin issues.
Tickets: