Change ov::parallel_for to CpuParallel::parallel_for by sunxiaoxia2022 · Pull Request #33244 · openvinotoolkit/openvino

sunxiaoxia2022 · 2025-12-15T01:35:58Z

Details:

Changed partial ov::parallel_for to CpuParallel::parallel_for in which can set TBB partitioner to AUTO or STATIC

Tickets:

CVS-177452

Copilot

Pull request overview

This PR refactors the Intel CPU plugin to use CpuParallel::parallel_for instead of ov::parallel_for throughout the codebase. This change enables more flexible control over TBB partitioning strategies (AUTO or STATIC) for parallel operations.

Key Changes:

Replaced ov::parallel_for calls with CpuParallel::parallel_for across numerous node implementations
Added cpuParallel member variables to various executor and node classes
Updated constructors and method signatures to accept and store CpuParallel instances
Extended CpuParallel class with parallel_sum2d and parallel_sum3d methods

Reviewed changes

Copilot reviewed 79 out of 79 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cpu_parallel.hpp	Added parallel_sum2d and parallel_sum3d methods to CpuParallel class
cpu_memory.cpp/h	Updated split_vertical to accept cpuParallel parameter
tile.h/cpp	Added cpuParallel member and updated optimizedExecute call
tensoriterator.h/cpp	Added cpuParallel to DynamicBuffer constructor and copy method
stft.cpp	Updated transpose_out4d and RDFTExecutor::build calls with cpuParallel
split.h/cpp	Added cpuParallel to SplitOptimizedExecutor
space_to_depth.h/cpp	Added cpuParallel to executor attributes and PermuteKernel
shuffle_channels.h/cpp	Added cpuParallel to executor attributes and PermuteKernel
scaled_attn.cpp	Updated parallel operations with cpuParallel throughout attention kernels
rope.cpp	Added cpuParallel to all RoPE executor variants
roll.h/cpp	Added cpuParallel to RollExecutor
roi_pooling.h/cpp	Added cpuParallel to executor constructors and key
rms_norm.cpp	Added cpuParallel to RMSNormExecutor
region_yolo.cpp	Updated SoftmaxGeneric constructor with cpuParallel
rdft.h/cpp	Added cpuParallel to RDFTExecutor and build method
proposal_imp.hpp/cpp	Added cpuParallel parameter to proposal_exec and helper functions
proposal.cpp	Updated proposal_exec call with cpuParallel
paged_attn.cpp	Updated make_pa_executor call with cpuParallel
pad.h/cpp	Added cpuParallel to attrs and used in padConstantCommon
normalize.h/cpp	Added cpuParallel to executor constructors and key
mvn.cpp	Added cpuParallel to MVNAttrs and updated parallel operations
mha_single_token.hpp/cpp	Added cpuParallel parameter to mha_single_token function
executor_pa.hpp/cpp	Added cpuParallel to AttentionExecutor constructors
attn_quant.hpp/cpp	Added cpuParallel to quantization functions
attn_memcpy.hpp/cpp	Added cpuParallel to memory copy functions
istft.cpp	Added cpuParallel to istft_impl and transpose_out4d
interpolate.h/cpp	Added cpuParallel to executor base class and implementations
generate_proposals.cpp	Added cpuParallel to refine_anchors and helper functions
gathermatmul.cpp	Updated parallel_for calls with cpuParallel
gather_tree.h/cpp	Added cpuParallel to GatherTreeExecutor
fullyconnected.cpp	Updated split_vertical calls with cpuParallel
extract_image_patches.h/cpp	Added cpuParallel to executor constructors
experimental_detectron_roifeatureextractor.cpp	Added cpuParallel to ROIAlignForward_cpu_kernel
experimental_detectron_generate_proposals_single_image.cpp	Added cpuParallel to refine_anchors and helper functions
jit_transpose.cpp	Updated PermuteKernel constructor with cpuParallel
eltwise.hpp/cpp	Added cpuParallel to EltwiseRefExecutor and BitwiseRefExecutor
mvn.hpp	Added cpuParallel to MVNAttrs structure
kleidiai_mm.hpp/cpp	Added cpuParallel member and updated parallel operations
ref_opt_transpose.cpp	Added cpuParallel to transpose functions
executor.hpp	Added getCpuParallel method to ExecutorContext
dft.h/cpp	Changed generateTwiddlesDFT to non-static and added cpuParallel usage
depth_to_space.h/cpp	Added cpuParallel to executor attributes and PermuteKernel
def_conv.h/cpp	Added cpuParallel to DefConvExecutor constructors
tile_broadcast_utils.h/cpp	Added cpuParallel parameter to optimizedExecute
softmax.h/cpp	Added cpuParallel to SoftmaxGeneric constructor
permute_kernel.h/cpp	Added cpuParallel to PermuteKernel constructor
color_convert.h/cpp	Added cpuParallel to Converter constructors
causal_mask_preprocess.cpp	Added cpuParallel to ExecutorCausalMaskPreprocess
broadcast.h/cpp	Added cpuParallel member and updated optimizedExecute call

Comments suppressed due to low confidence (2)

src/plugins/intel_cpu/src/nodes/color_convert.cpp:1

Corrected spelling of 'cpu_arallel' to 'cpu_parallel'.

// Copyright (C) 2018-2025 Intel Corporation

src/plugins/intel_cpu/src/nodes/executors/kleidiai/kleidiai_mm.cpp:1

Corrected spelling of 'cpu_arallel' to 'cpu_parallel'.

// Copyright (C) 2023 Intel Corporation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/plugins/intel_cpu/src/cpu_parallel.hpp

src/plugins/intel_cpu/src/nodes/executors/kleidiai/kleidiai_mm.cpp

src/plugins/intel_cpu/src/nodes/color_convert.h

src/plugins/intel_cpu/src/nodes/color_convert.cpp

src/plugins/intel_cpu/src/nodes/depth_to_space.h

src/plugins/intel_cpu/src/nodes/executors/mvn.hpp

src/plugins/intel_cpu/src/nodes/interpolate.cpp

src/plugins/intel_cpu/src/nodes/shuffle_channels.h

src/plugins/intel_cpu/src/nodes/space_to_depth.h

src/plugins/intel_cpu/src/nodes/split.h

src/plugins/intel_cpu/src/nodes/stft.cpp

src/plugins/intel_cpu/src/nodes/tile.h

maxnick · 2026-01-29T10:26:03Z

src/plugins/intel_cpu/src/nodes/kernels/scaled_attn/executor_pa.cpp

    }

-    explicit MHAHelper(const ov::Extensions::Cpu::PagedAttnQuantParams& params) : _params(params) {
+    explicit MHAHelper(const std::shared_ptr<CpuParallel>& cpu_arallel) : _cpu_parallel(cpu_arallel) {


Suggested change

explicit MHAHelper(const std::shared_ptr<CpuParallel>& cpu_arallel) : _cpu_parallel(cpu_arallel) {

explicit MHAHelper(const std::shared_ptr<CpuParallel>& cpu_arallel) : _cpu_parallel(cpu_parallel) {

A typo

maxnick · 2026-01-29T10:36:34Z

src/plugins/intel_cpu/src/nodes/extract_image_patches.h


    private:
        std::unique_ptr<jit_uni_extract_image_patches_kernel> pKernel;
+        CpuParallelPtr cpuParallel = nullptr;


Do we still need to store the pointer, when the parallel object is passed into the exec call?

maxnick · 2026-01-29T10:36:53Z

src/plugins/intel_cpu/src/nodes/extract_image_patches.h


    private:
        jit_extract_image_patches_params jpp;
+        CpuParallelPtr cpuParallel = nullptr;


Do we still need to store the pointer, when the parallel object is passed into the exec call?

maxnick · 2026-01-29T10:46:23Z

src/plugins/intel_cpu/src/cpu_parallel.hpp

+
+using CpuParallelPtr = std::shared_ptr<ov::intel_cpu::CpuParallel>;


Likely it should be inside the ov::intel_cpu namespace.

change parallel_for to cpuParallel->parallel_for

5acdb34

sunxiaoxia2022 requested a review from wangleis December 15, 2025 01:35

sunxiaoxia2022 requested review from a team as code owners December 15, 2025 01:35

github-actions bot added the category: CPU OpenVINO CPU plugin label Dec 15, 2025

sunxiaoxia2022 added 14 commits December 16, 2025 21:28

change some parallel_for to auto

f6aafcf

add some parallel to cpu_parallel

8ed2657

update parallel_for in dft

d4dca59

update parallel in color_convert

feb4f8c

fix conflict

7065083

fix code style

2137288

code style

5afceb3

fix Clang-tidy issue

a23d9db

Clang-tidy issue

42a9f1c

Clang-tidy

27c9e48

Clang-tidy

e602707

clang-tidy

494bb9d

clang-tidy

9be399f

fix test failure

20fd0c2

maxnick requested a review from Copilot January 8, 2026 09:20

maxnick added this to the 2026.0 milestone Jan 8, 2026

maxnick self-assigned this Jan 8, 2026

Copilot AI reviewed Jan 8, 2026

View reviewed changes

src/plugins/intel_cpu/src/cpu_parallel.hpp Outdated Show resolved Hide resolved

src/plugins/intel_cpu/src/nodes/executors/kleidiai/kleidiai_mm.cpp Outdated Show resolved Hide resolved

add const

8334f83

wangleis approved these changes Jan 12, 2026

View reviewed changes

maxnick requested changes Jan 12, 2026

View reviewed changes

sunxiaoxia2022 added 3 commits January 17, 2026 19:43

pass cpuParallel to the execute method

5666a4c

fix code style

132b5f1

fix ci issue

38fe348

sunxiaoxia2022 requested a review from maxnick January 17, 2026 12:34

sunxiaoxia2022 added 5 commits January 17, 2026 21:18

clang issue

ad0e817

fix code style

f0e10d9

fix clang-tidy issue

8c13666

Merge branch 'master' into xiaoxia/parallel_for_auto_2.0

a669ede

Merge branch 'master' into xiaoxia/parallel_for_auto_2.0

ad33939

maxnick modified the milestones: 2026.0, 2026.1 Jan 23, 2026

maxnick reviewed Jan 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change ov::parallel_for to CpuParallel::parallel_for#33244

Change ov::parallel_for to CpuParallel::parallel_for#33244
sunxiaoxia2022 wants to merge 24 commits intoopenvinotoolkit:masterfrom
sunxiaoxia2022:xiaoxia/parallel_for_auto_2.0

sunxiaoxia2022 commented Dec 15, 2025 •

edited by peterchen-intel

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxnick Jan 29, 2026

Uh oh!

maxnick Jan 29, 2026

Uh oh!

maxnick Jan 29, 2026

Uh oh!

maxnick Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	explicit MHAHelper(const std::shared_ptr<CpuParallel>& cpu_arallel) : _cpu_parallel(cpu_arallel) {
	explicit MHAHelper(const std::shared_ptr<CpuParallel>& cpu_arallel) : _cpu_parallel(cpu_parallel) {


		using CpuParallelPtr = std::shared_ptr<ov::intel_cpu::CpuParallel>;

Conversation

sunxiaoxia2022 commented Dec 15, 2025 • edited by peterchen-intel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details:

Tickets:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxnick Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

maxnick Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

maxnick Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

maxnick Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sunxiaoxia2022 commented Dec 15, 2025 •

edited by peterchen-intel

Loading