[GPU]fix error handler#33810
Open
openvino-dev-samples wants to merge 1 commit intoopenvinotoolkit:masterfrom
Open
[GPU]fix error handler#33810openvino-dev-samples wants to merge 1 commit intoopenvinotoolkit:masterfrom
openvino-dev-samples wants to merge 1 commit intoopenvinotoolkit:masterfrom
Conversation
ceciliapeng2011
approved these changes
Jan 26, 2026
| const std::string& additional_message) { | ||
| std::vector<std::string> errors; | ||
| if (tens.batch[0] % tens_to_compre.batch[0] != 0) { | ||
| if (tens_to_compre.batch[0] != 0 && tens.batch[0] % tens_to_compre.batch[0] != 0) { |
Contributor
There was a problem hiding this comment.
Maybe also add division by zero as an additional error?
Suggested change
| if (tens_to_compre.batch[0] != 0 && tens.batch[0] % tens_to_compre.batch[0] != 0) { | |
| if (tens_to_compre.batch[0] == 0 || tens.batch[0] % tens_to_compre.batch[0] != 0) { |
The same applies to other conditions
Contributor
Author
There was a problem hiding this comment.
In my case, the tens.batch[0] is 0 as well
rkazants
reviewed
Jan 27, 2026
Collaborator
rkazants
left a comment
rkazants
left a comment
There was a problem hiding this comment.
can you please implement tests to cover these cases?
Contributor
Author
Hi this PR is only for safety check before |
Contributor
|
build_jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checker for
tens_to_compre.batch[0] != 0