[GPU] Fix reshape in-place optimization with feature padding#33978
Open
zhanmyz wants to merge 1 commit intoopenvinotoolkit:masterfrom
Open
[GPU] Fix reshape in-place optimization with feature padding#33978zhanmyz wants to merge 1 commit intoopenvinotoolkit:masterfrom
zhanmyz wants to merge 1 commit intoopenvinotoolkit:masterfrom
Conversation
- Fix batch inconsistency error in reshape layer when input has feature upper padding - This occurs in BoxPredictor_5/Reshape [2,24,1,1]→[2,6,1,4] where input has upper_pad=[0,8,0,0] - Original has_outer_padding_offset() only checked lower padding of feature dimension, missing upper padding case - Modify has_outer_padding_offset() in reshape_inst.h to also check input_pad._upper_size[1] != 0 - This prevents incorrect in-place optimization when feature dimension has any padding - *CVS-175476* Signed-off-by: zhanmyz <yazhan.ma@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Description of the issue(symptom, root-cause, how it was resolved)
Symptom: TF_Ssd_Inception_v2_coco model produces incorrect inference results for batch=2 at BoxPredictor_5/Reshape layer [2,24,1,1]→[2,6,1,4].
Root Cause:
Resolution:
The code and line that caused this issue (if it is not changed directly)
openvino/src/plugins/intel_gpu/src/graph/include/reshape_inst.h
Lines 113 to 116 in 849a127
Reproduction step and snapshot (if applicable. Do not attach for customer model)
python -m pytest test_ovc_mo.py
-n 2
--tb=native
--env_conf=.automation/env_config.yml
--test_conf=.automation/test_configs/desktop_test_config_gpu_llm.yml
-m "not launch_only_if_manually_specified"
--pregen_irs=models/irs_mapping.csv
--tf_models_version=1.15.2
--modules pipelines/production/tf/light
-k "TF_Ssd_Inception_v2_coco_api_2_True"
--dynamism_type=None
--log-cli-level INFO
Problematic graph
Checklist
Tickets: