Refine .bat fix for escaped closing quote#33987
Refine .bat fix for escaped closing quote#33987Wovchena wants to merge 3 commits intoopenvinotoolkit:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the handling of escaped closing quotes in the batch file by moving the workaround earlier in the script. Instead of appending \. to SAMPLES_SOURCE_DIR when passing it to CMake, the fix now appends a dot directly when setting the variable, simplifying the code and removing verbose comments.
Changes:
- Modified
SAMPLES_SOURCE_DIRinitialization to append a dot, preventing the trailing backslash from escaping the closing quote - Updated the
FORloop to use the corrected directory path without needing\.workaround - Removed lengthy explanatory comments from the CMake command line, replacing them with concise comments at variable initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Details: