Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credo integration PR - squashed commits #38

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

jrhender
Copy link
Contributor

@jrhender jrhender commented Oct 1, 2024

This PR is the same content as PR #36 but:

  • Rebased from develop
  • Commits are squashed to keep the commit history cleaner

ShikharBhatt and others added 4 commits October 1, 2024 14:41
Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: mesaresachin <sachin.mesare@impactility.com>
Signed-off-by: jrhender <john.henderson@energyweb.org>
Signed-off-by: jrhender <john.henderson@energyweb.org>
@jrhender jrhender changed the title Squashed credo Credo integration PR - squashed commits Oct 1, 2024
ShikharBhatt and others added 2 commits October 3, 2024 07:42
- replace better-sqlite3 with sqlite
- rename in-memory-db.ts to db-config.ts
- TypeOrmSQLiteModule to accept inMemory boolean param; helps in db initialization for app and unit tests

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Changed from node-alpine to base node.
node-alpine was missing shared library ld-linux-x86-64.so.2.
This lib is required by Askar.

Also removed unneeded package installs.

Signed-off-by: jrhender <john.henderson@energyweb.org>
@jrhender jrhender merged commit 4d4ae7b into develop Oct 3, 2024
3 checks passed
@jrhender jrhender deleted the squashed-credo branch October 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants