fix: tenant access to endpoints leading to access the base wallet #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thiago Romano <thiagoromano.s@gmail.com>
dbluhm
previously approved these changes
Feb 28, 2025
|
Looks like one of the tests was perhaps encoded to expect the original behavior |
|
Found the test that was failing. Now, the question is, |
Signed-off-by: Thiago Romano <thiagoromano.s@gmail.com>
|
jamshale
approved these changes
Feb 28, 2025
jamshale
reviewed
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using acapy with
multitenantenabled andadmin-insecure-mode, tenant endpoints (like[GET] /wallet/didfor example) could be accessed without a bearer token.With this fix, single tenant agents will access agent's endpoints with no problem, and multi-tenant agents will require a bearer token to access those endpoints.