Update 0.4-to-0.5.md - VL-8611-acceptCredentialOfferUsingPreAuthorizedCode is DEPRECATED #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Avoyan <64565419+michaelavoyan@users.noreply.github.com>
michaelavoyan
force-pushed
the
VL-8611-acceptCredentialOfferUsingPreAuthorizedCode-DEPRECATED
branch
from
70f1b5d to
fed942d
Compare
Signed-off-by: Michael Avoyan <64565419+michaelavoyan@users.noreply.github.com>
michaelavoyan
force-pushed
the
VL-8611-acceptCredentialOfferUsingPreAuthorizedCode-DEPRECATED
branch
from
c7fa4b1 to
d27ea65
Compare
Author
|
@daidoji @ryjones @jakubkoci @2byrds please review |
TimoGlastra
reviewed
Mar 2, 2025
| ) | ||
| const credentials = await holder.modules.openId4VcHolderModule.requestCredentials({ | ||
| resolvedCredentialOffer, | ||
| token, |
Contributor
There was a problem hiding this comment.
A lot of the parameters are removed which are still used. Also these methods were only introduced in later 0.5 versions so we might want to add this to 0.6 migration guide?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the source doc
acceptCredentialOfferUsingPreAuthorizedCodemethod is deprecated.requestTokenandrequestCredentialsshould be used instead.