Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push-notifications)!: align to RFCs 0699/0734 #223

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Aug 5, 2023

Updates Push Notifications modules to support all features mentioned in Aries RFCs 0699 (for APNS) and 0734 (for FCM).

There are only two changes in the API for both mechanisms:

  • deviceInfo() now needs an additional parameter, because to create a device-info message it's needed to specify the threadId (as it is generated as a response for a get-device-info message)
  • DeviceInfo data can now accept both string and null

This adds some basic error handling, like throwing a Problem Report in case that either device_token or device_platform are null. Maybe it could be interesting in a further PR to add records (or use Connection Metadata) to do automated responses and more checks.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner August 5, 2023 14:11
@codecov-commenter
Copy link

Codecov Report

Merging #223 (334d9e9) into main (6827127) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files          24       24           
  Lines        1241     1241           
  Branches      270      270           
=======================================
  Hits         1077     1077           
  Misses        164      164           

see 2 files with indirect coverage changes

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris enabled auto-merge (squash) August 14, 2023 21:46
@genaris genaris merged commit 15e9f1f into openwallet-foundation:main Aug 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants