fix(push-notifications)!: align to RFCs 0699/0734 #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Push Notifications modules to support all features mentioned in Aries RFCs 0699 (for APNS) and 0734 (for FCM).
There are only two changes in the API for both mechanisms:
deviceInfo()
now needs an additional parameter, because to create adevice-info
message it's needed to specify the threadId (as it is generated as a response for aget-device-info
message)DeviceInfo
data can now accept bothstring
andnull
This adds some basic error handling, like throwing a Problem Report in case that either device_token or device_platform are null. Maybe it could be interesting in a further PR to add records (or use Connection Metadata) to do automated responses and more checks.